Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink exported types in sdk-starter-kit #1052

Open
yagopv opened this issue Nov 18, 2024 · 0 comments
Open

Rethink exported types in sdk-starter-kit #1052

yagopv opened this issue Nov 18, 2024 · 0 comments

Comments

@yagopv
Copy link
Member

yagopv commented Nov 18, 2024

Context

The extend() method in the sdk-starter-kit does not work well with typing across different files where the extend variable is not defined. Currently, we only export a SafeClient type, which complicates the use of extensions in the projects using the kit.

For example, we had to implement a special SafeClient in the safe-react-hooks to resolve TypeScript errors.

Proposed solution

Export the main types from the sdk-starter-kit, such as a SafeOperationsClient type, that can be used in other projects without needing to define it explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant