Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onchain trackid via paymentReceiver & refundReceiver #1057

Closed
wants to merge 3 commits into from

Conversation

DaniSomoza
Copy link
Contributor

What it solves

Resolves #1056

How this PR fixes it

Added on chain tracking via paymentReceiver & refundReceiver fields

Examples

Safe Deployment

Safe creation (v1.3.0)

Chain: Sepolia

TrackId: mi-test-track-id
Hashed trackId: 0xdda6d6dcc0edd564c5393808feb3b4e49d100cfe

Safe deployed v1.3.0 address: 0x00088ef66C3F981b07DB931f2302Ed1eB412E055

Deployment Link: https://sepolia.etherscan.io/tx/0xb0763692d198fb5df5546e3fa4bf3c431111c8aaf1010816924173c06f6e292d

Tenderly Link: https://dashboard.tenderly.co/tx/sepolia/0xb0763692d198fb5df5546e3fa4bf3c431111c8aaf1010816924173c06f6e292d/debugger?trace=0.1.1

Safe creation (v1.0.0)

Chain: gnosis

TrackId: mi-test-track-id
Hashed trackId: 0xdda6d6dcc0edd564c5393808feb3b4e49d100cfe

Safe deployed v1.0.0 address: 0x86e06Eb38B5f202a92417d06f20881B827d683CA

Deployment Link: https://gnosisscan.io/tx/0xc9803c5f2c38374d8705020ebf9600a4357c0d9e6a310dd04a3fd06d53dbdfb1

Tenderly Link: https://dashboard.tenderly.co/tx/gnosis-chain/0xc9803c5f2c38374d8705020ebf9600a4357c0d9e6a310dd04a3fd06d53dbdfb1/debugger?trace=0.1.0

Safe Execution

Chain: Sepolia

TrackId: mi-test-track-id
Hashed trackId: 0xdda6d6dcc0edd564c5393808feb3b4e49d100cfe

Safe v1.3.0 address: 0x00088ef66C3F981b07DB931f2302Ed1eB412E055

Tenderly Link: https://dashboard.tenderly.co/tx/sepolia/0x8d5871a6f668a3b4441f92d6f854c66dccc51ef53d3ae3362f7806c3011b1d4a/debugger?trace=0.1.3

transaction Hash: 0x8d5871a6f668a3b4441f92d6f854c66dccc51ef53d3ae3362f7806c3011b1d4a

@DaniSomoza DaniSomoza changed the base branch from main to development November 21, 2024 19:01
@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 12006838175

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.515%

Totals Coverage Status
Change from base Build 11742341140: 0.0%
Covered Lines: 786
Relevant Lines: 970

💛 - Coveralls

@yagopv
Copy link
Member

yagopv commented Nov 22, 2024

@DaniSomoza hey, i think you are adding the trackId to the safe transaction data right?

The trackId needs to be added to the Ethereum transaction data field because you cannot alter the information of the safe data field

cc: @akshay-ap

@DaniSomoza
Copy link
Contributor Author

i think you are adding the trackId to the safe transaction data right?

No, we have 2 different POC to implement the on chain tracking. In this PR we are implementing the trackId in the paymentReceiver & refundReceiver fields.

this is the PR that adds the trackId to the safe transaction data field.

@DaniSomoza
Copy link
Contributor Author

I'm closing this PR because it was intended as a proof of concept (PoC). After discussing with the team, we've decided to implement the alternative approach, appending the onchain identifier to the end of the data and calldata fields in transactions.

The final implementation can be found in this other PR: #1059

@DaniSomoza DaniSomoza closed this Nov 28, 2024
@DaniSomoza DaniSomoza deleted the onchain-trackid-address branch November 28, 2024 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Onchain tracking] PoC
3 participants