Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI with local install #118

Closed
choomz opened this issue Oct 5, 2023 · 4 comments
Closed

Web UI with local install #118

choomz opened this issue Oct 5, 2023 · 4 comments
Assignees

Comments

@choomz
Copy link

choomz commented Oct 5, 2023

Hello,

Currently, when you run the run_locally.sh script, the UI container doesn't launch because it can't compile the contracts.
image (1)

If you dig a little deeper, the yarn after-install script doesn't run during assembly :
https://github.com/safe-global/safe-wallet-web/blob/dev/package.json#L22

By explicitly adding the script with a command in the docker-compose.yml, it works:
image

I'm opening this issue if it helps anyone and if the team wants to fix it. This issue seems to be related: #116

Thanks :)

@JABirchall
Copy link

Im getting the same issue. The UI container is crashing because of build errors.

2023-10-28 05:04:27 yarn run v1.22.19
2023-10-28 05:04:27 $ yarn build && yarn serve
2023-10-28 05:04:27 $ next build
2023-10-28 05:04:29 - info Linting and checking validity of types...
2023-10-28 05:05:12 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2023-10-28 05:05:12 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2023-10-28 05:28:41 yarn run v1.22.19
2023-10-28 05:28:42 $ yarn build && yarn serve
2023-10-28 05:28:42 $ next build
2023-10-28 05:28:47 - info Linting and checking validity of types...
2023-10-28 05:28:57 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2023-10-28 05:28:57 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2023-10-28 05:05:12 Failed to compile.
2023-10-28 05:05:12 
2023-10-28 05:05:12 ./src/components/tx/ApprovalEditor/utils/approvals.ts:1:32
2023-10-28 05:05:12 Type error: Cannot find module '@/types/contracts' or its corresponding type declarations.
2023-10-28 05:05:12 
2023-10-28 05:05:12 > 1 | import { ERC20__factory } from '@/types/contracts'
2023-10-28 05:05:12     |                                ^
2023-10-28 05:05:12   2 | import { UNLIMITED_APPROVAL_AMOUNT } from '@/utils/tokens'
2023-10-28 05:05:12   3 | import type { BaseTransaction } from '@safe-global/safe-apps-sdk'
2023-10-28 05:05:12   4 | import type { DecodedDataResponse, TokenInfo } from '@safe-global/safe-gateway-typescript-sdk'
2023-10-28 05:05:12 error Command failed with exit code 1.
2023-10-28 05:05:12 error Command failed with exit code 1.
2023-10-28 05:28:57 Failed to compile.
2023-10-28 05:28:57 
2023-10-28 05:28:57 ./src/components/tx/ApprovalEditor/utils/approvals.ts:1:32
2023-10-28 05:28:57 Type error: Cannot find module '@/types/contracts' or its corresponding type declarations.
2023-10-28 05:28:57 
2023-10-28 05:28:57 > 1 | import { ERC20__factory } from '@/types/contracts'
2023-10-28 05:28:57     |                                ^
2023-10-28 05:28:57   2 | import { UNLIMITED_APPROVAL_AMOUNT } from '@/utils/tokens'
2023-10-28 05:28:57   3 | import type { BaseTransaction } from '@safe-global/safe-apps-sdk'
2023-10-28 05:28:57   4 | import type { DecodedDataResponse, TokenInfo } from '@safe-global/safe-gateway-typescript-sdk'
2023-10-28 05:28:57 error Command failed with exit code 1.
2023-10-28 05:28:57 error Command failed with exit code 1.

@Uxio0
Copy link
Member

Uxio0 commented Nov 8, 2023

This will be fixed by safe-global/safe-wallet-monorepo#2771

@Uxio0
Copy link
Member

Uxio0 commented Nov 14, 2023

Fixed

@Uxio0 Uxio0 closed this as completed Nov 14, 2023
@JagoFigueroa
Copy link

Was able to try this yesterday and works nicely for me, thank you! Let us know if you encounter any issues after the fix 😄

@Uxio0 Uxio0 self-assigned this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants