Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxZoomFactor should apply on top of any zoom applied by the content scale #45

Open
MV-GH opened this issue Sep 4, 2023 · 5 comments
Open

Comments

@MV-GH
Copy link

MV-GH commented Sep 4, 2023

Something that I have noticed is that zoomlevel seems very inconsistent. Sometimes I can barely zoom at all.

studio64_E1cOJMEQex.mp4

For now I have countered this by doing 20x.

see repro: https://github.com/MV-GH/ReproChannelCrash/tree/bug/inconsisent_zoom

@saket
Copy link
Owner

saket commented Sep 4, 2023

I can see why this can be confusing, but the explanation is that that image is already max zoomed in to fit its bounds. This can be verified by changing the contentScale to ContentScale.Inside:

zoom.mp4

@MV-GH
Copy link
Author

MV-GH commented Sep 5, 2023

I see, from a technical perspective this indeed correct. But from a user perspective it does feel like one image can be zoomed in more than others. Which was the feedback i was getting. Maybe a option where it starts the zoomlevel from the size it takes up? It is not really needed for me as the users just wanted a "limitless" zoom. So I have set to a rather big number. You can close this if you want.

@saket
Copy link
Owner

saket commented Sep 5, 2023

Agree, I'll think more about this.

It is not really needed for me as the users just wanted a "limitless" zoom. So I have set to a rather big number.

This unfortunately has a downside that double tapping images in your app will zoom them all the way to 20x.

@MV-GH
Copy link
Author

MV-GH commented Sep 5, 2023

I see, #32 could help with that

@saket saket changed the title ZoomFactor seems inconsistent maxZoomFactor should apply on top of any zoom applied by the content scale Sep 5, 2023
@saket saket added the 0.8.0 label Nov 13, 2023
@saket saket removed the 0.9.0 label Apr 27, 2024
@FooIbar
Copy link
Contributor

FooIbar commented Jul 23, 2024

Yeah, we would like to have something like maxUserZoom instead of the current maxZoomFactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants