From e164d6aba25c40884c3a8b3a5365a4ddac92ab29 Mon Sep 17 00:00:00 2001 From: Lukasz Ostrowski Date: Wed, 6 Dec 2023 21:28:13 +0100 Subject: [PATCH] restore otel method name --- .changeset/early-mails-explain.md | 5 +++++ src/APL/saleor-cloud/saleor-cloud-apl.ts | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 .changeset/early-mails-explain.md diff --git a/.changeset/early-mails-explain.md b/.changeset/early-mails-explain.md new file mode 100644 index 00000000..462a21b5 --- /dev/null +++ b/.changeset/early-mails-explain.md @@ -0,0 +1,5 @@ +--- +"@saleor/app-sdk": patch +--- + +Removed OTEL attribute http.method. It eventually caused bad mapping in Datadog -> overwriting span name diff --git a/src/APL/saleor-cloud/saleor-cloud-apl.ts b/src/APL/saleor-cloud/saleor-cloud-apl.ts index fb3a8fad..1592398f 100644 --- a/src/APL/saleor-cloud/saleor-cloud-apl.ts +++ b/src/APL/saleor-cloud/saleor-cloud-apl.ts @@ -140,7 +140,6 @@ export class SaleorCloudAPL implements APL { attributes: { saleorApiUrl, [SemanticAttributes.PEER_SERVICE]: OTEL_APL_SERVICE_NAME, - [SemanticAttributes.HTTP_METHOD]: "GET", }, kind: SpanKind.CLIENT, }, @@ -269,7 +268,6 @@ export class SaleorCloudAPL implements APL { saleorApiUrl: authData.saleorApiUrl, appId: authData.appId, [SemanticAttributes.PEER_SERVICE]: OTEL_APL_SERVICE_NAME, - [SemanticAttributes.HTTP_METHOD]: "POST", }, kind: SpanKind.CLIENT, },