Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] What is the goal of this formula? Why including other states like postgresql here? #49

Open
Darkentik opened this issue Sep 26, 2023 · 1 comment
Labels

Comments

@Darkentik
Copy link

Hey,
i wonder why here are included more than icinga2 states such like postgresql, that have their own formula.
I think this is not a good idea.
According to my other question about HA setup with satellites and more, i think that it would be better to focus on icinga2 components only.
Maybe we could split icingaweb2 as own state into its own formula.
In our company we follow a service splitting concept so we have our icinga stack with icinga master, icingaweb2, mariadb server, grafana and influxdb all on separate virtuell machines on each location.

I am interested in hearing your opinions.

Best regards,
Darkentik

@Darkentik Darkentik added the bug label Sep 26, 2023
@alxwr
Copy link
Member

alxwr commented Feb 9, 2024

Hi, Darkentik!

The main reason (at the time) was to provide an easy way to set up PostgreSQL, iirc.

After a quick look at https://github.com/saltstack-formulas/icinga2-formula/blob/master/icinga2/postgresql-server.sls I suggest the following:

  • make use_formula: True the default
  • move the 'use the formula' parts to icinga2/icinga-web2.sls
  • drop icinga2.postgresql.server
  • drop icinga2.postgresql.client

Wdyt? @Darkentik @baby-gnu

PS
Sry for the long delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants