Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Refactor retry argument attributes #22

Open
jmgate opened this issue Jun 25, 2024 · 0 comments · Fixed by #40
Open

BREAKING: Refactor retry argument attributes #22

jmgate opened this issue Jun 25, 2024 · 0 comments · Fixed by #40
Assignees
Labels
Stage: Next Release Merged into the `next` branch for the next major release. Type: Refactor Refactoring existing code to improve long-term sustainability.

Comments

@jmgate
Copy link
Collaborator

jmgate commented Jun 25, 2024

Mypy doesn't like that the retry argument attributes are defined dynamically when a class is instantiated, so it'll complain that they don't exist when a subclass developer is trying to modify them when overriding/extending the parser. If instead of having separate attributes per registered stage, we just had a dict where the keys are the stage names, mypy would be happy.

Note: This will be a breaking change.

@jmgate jmgate added the Type: Refactor Refactoring existing code to improve long-term sustainability. label Jun 25, 2024
@jmgate jmgate self-assigned this Jun 25, 2024
@jmgate jmgate changed the title Refactor retry argument attributes BREAKING: Refactor retry argument attributes Jun 25, 2024
@jmgate jmgate added Stage: Development Someone's working on this currently. Stage: Review A pull request is being reviewed. Stage: Next Release Merged into the `next` branch for the next major release. and removed Stage: Development Someone's working on this currently. Stage: Review A pull request is being reviewed. labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stage: Next Release Merged into the `next` branch for the next major release. Type: Refactor Refactoring existing code to improve long-term sustainability.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant