-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP-514 support was removed in version 2.0 but is still documented #158
Comments
This is something I am supportive of improving/fixing in terms of restoring the functionality. Is there a way to do so without vendoring in |
You'd have to implement the same registry searching logic documented in PEP-514. I had a quick look last month, and my recollection is that this is basically all pep514tools is doing, and it probably hasn't been updated because there's nothing that needs to change: The algorithm was finalised in 2016. Although looking closer, I see some issues are open and unaddressed, including yours, so a local PEP-514 consumer implementation should be pretty simple. (pep514tools also supports manipulating the PEP 514 data, and we don't need that here) |
I haven't forgotten about this, here is my draft attempt: pypa/pipenv#6140 I made it against pipenv to run with the full test suite there and plan to backport the changes to a PR here. |
PR #135 removed
WindowsFinder
(which wrapped the vendored pep514tools library) and did not replace it with any equivalent support for PEP-514.As noted in the PR description, this was somewhat intended, as it removed Windows-specific support (leaving only PATH-env searching), and PEP-514 is a Windows-specific mechanism.
However, the documentation was not updated for this change, and still claims PEP-514 compatibility, including a pep514 tag on PyPI.
Testing results on a Windows system with Python 3.9 and 3.10 installed but not in the PATH (inside a venv, I believe):
The system's PyLauncher details:
See also #135 (comment) and python-poetry/poetry#2117 (comment)
The text was updated successfully, but these errors were encountered: