Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log color issue #1346

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: log color issue #1346

merged 1 commit into from
Jan 6, 2025
+9 −4

Conversation

scnwwu
Copy link
Member

@scnwwu scnwwu commented Jan 2, 2025

Summary
Fix #1325
The line returned by server appears to contain \n in this case

Testing
Test case in #1325

@scnwwu scnwwu requested review from boyce-w and scnjdl January 2, 2025 06:38
@scnwwu scnwwu added this to the 1.14.0 milestone Jan 2, 2025
@enzhihpp enzhihpp assigned Zhirong2022 and unassigned enzhihpp Jan 3, 2025
@Zhirong2022 Zhirong2022 added testing Test the pull requests and removed verification-needed labels Jan 6, 2025
@Zhirong2022
Copy link
Collaborator

The log color works as expected.
image

@Zhirong2022 Zhirong2022 added testing-complete Complete the pull requests testing and removed testing Test the pull requests labels Jan 6, 2025
@scnwwu scnwwu merged commit 122a4a5 into sassoftware:main Jan 6, 2025
2 checks passed
@scnwwu scnwwu deleted the p-multilinelog branch January 6, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhirong2022 Zhirong2022 Zhirong2022 approved these changes

@scnjdl scnjdl scnjdl approved these changes

@boyce-w boyce-w Awaiting requested review from boyce-w

Assignees

@Zhirong2022 Zhirong2022

Labels
testing-complete Complete the pull requests testing
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

The color of log contents is not correct on log output panel
4 participants
@scnwwu @Zhirong2022 @scnjdl @enzhihpp