Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A "flexible interface" for diagnostic tools #1330

Open
michaeldeistler opened this issue Dec 11, 2024 · 1 comment
Open

A "flexible interface" for diagnostic tools #1330

michaeldeistler opened this issue Dec 11, 2024 · 1 comment
Labels
enhancement New feature or request hackathon

Comments

@michaeldeistler
Copy link
Contributor

In a couple of issues now, users have reported memory issues with SBC. I think the easiest way to overcome these issues is to introduce a whole new interface for SBC which might contain a couple of lines of code but which gives much more flexibility.

The other option is to just adding more and more kwargs to run_sbc, but I would really be in favor of just developing a new interface.

@michaeldeistler michaeldeistler added enhancement New feature or request hackathon labels Dec 11, 2024
@janfb
Copy link
Contributor

janfb commented Dec 11, 2024

In the refactoring #1196 we already separated the sampling from the run_{sbc, tarp}. So in principle, it's possible to do things more low-level, e.g., first generate posterior samples on a test set, and pass them to sbc and tarp without having to pass a posterior for sampling anymore. But this is not documented well.

But overall, I agree: we should think about a more elegant interface for the diagnostics in general. First, something more high-level like sbi.train() -> sbi.build_posterior() -> sbi.diagnose() and something more low-level like you are suggesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hackathon
Projects
None yet
Development

No branches or pull requests

2 participants