Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in the value of the "persistent" attribute #363

Open
sbmlsecretary opened this issue Feb 5, 2020 · 2 comments
Open

Possible typo in the value of the "persistent" attribute #363

sbmlsecretary opened this issue Feb 5, 2020 · 2 comments

Comments

@sbmlsecretary
Copy link
Contributor

SBML Level 3 Version 2 Core, Release 2, 29 March 2019

Page 84, lines 17–18.

My understanding is that the purpose of the condition «that either (i) have Trigger objects with attributes persistent=“false” or (ii) have Trigger expressions that did not transition from “true” to “false”» is to ensure that these events are still scheduled for execution. In that case, shouldn't it say persistent=“true” rather than "false"?

Reported by: rcnova

Original Ticket: sbml/sbml-specifications//365

@sbmlsecretary
Copy link
Contributor Author

Hi – that particular passage is about events that have not been triggered. What it's trying to say is, for all the events that didn't get triggered, there's a chance that the events that did get triggered change the priority of the untriggered events. So, after the triggered events fire, the priorities of the remaining events should be reevaluated before picking which event(s) fire in the next round.

Original comment by: mhucka

@sbmlsecretary
Copy link
Contributor Author

Dear Michael,

Thank you for the response.

First, I assume that by "triggered" you mean "executed" (i.e. their assignments got applied), and not merely that their trigger evaluates to true.

So what you're saying is that the executed events may change the priorities of the events that haven't been executed—that makes sense.

My specific issue with that passage is the specific condition on lines 17–18 that says «that either (i) have Trigger objects with attributes persistent=“false” or (ii) have Trigger expressions that did not transition from “true” to “false”». In order for an event to remain "triggered" (scheduled for execution) after the execution of the previous events, the event either has to have persistent="true" (not false, as the spec currently says) or a Trigger expression that still evaluats to true.

Original comment by: rcnova

@sbmlsecretary sbmlsecretary self-assigned this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant