Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depend on btrfs-progs directly instead of python bindings #7

Closed
sbrudenell opened this issue Apr 30, 2024 · 1 comment
Closed

depend on btrfs-progs directly instead of python bindings #7

sbrudenell opened this issue Apr 30, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@sbrudenell
Copy link
Owner

the libbtrfsutil python bindings are pretty cumbersome. they're not in pypi, and they really can't be, because they need to be compiled against your kernel. this means they need to be installed from a system package manager, and virtualenvs need to be created with --system-site-packages, and can only be created with the system package manager's chosen python version. at minimum this creates speed bumps, at worst this could make installs impossible.

we have a dependency on the btrfs-progs CLI program directly, because this is currently the only way to access btrfs send.

it would be nice if we could just similarly use btrfs --format=json subvolume show instead of btrfsutil.subvolume_info().

the difficulty is that it seems support for btrfs --format=json subvolume show was only introduced in v6.5, which is pretty recent. a dependency v6.5 would restrict installations even more than the current setup. we could parse the output of --format=text, I suppose.

@sbrudenell sbrudenell added duplicate This issue or pull request already exists enhancement New feature or request labels Jun 30, 2024
@sbrudenell
Copy link
Owner Author

this grew into #27 and I wrote more there

@sbrudenell sbrudenell closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant