Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shading breaks META-INF/services (1.2.0 regression) #515

Open
piotrp opened this issue Nov 20, 2023 · 2 comments
Open

Shading breaks META-INF/services (1.2.0 regression) #515

piotrp opened this issue Nov 20, 2023 · 2 comments

Comments

@piotrp
Copy link

piotrp commented Nov 20, 2023

Enabling shading by setting assemblyShadeRules makes some files in META-INF/services empty, an example is org.apache.kafka.common.config.provider.ConfigProvider from Kafka client library.

Sample project

project/build.properties

sbt.version=1.9.7

project/plugins.sbt

addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.1.4")

build.sbt

ThisBuild / version := "0.1"
ThisBuild / assembly / logLevel := Level.Debug
ThisBuild / assembly / assemblyShadeRules := Seq(
  ShadeRule.rename("xyz.**" -> "shaded.xyz.@1").inAll
)

libraryDependencies ++= Seq(
  "org.apache.kafka" % "kafka-clients" % "3.3.2"
)

lazy val assemblyTest = project in file(".")
@piotrp piotrp changed the title Shading breaks META-INF/services Shading breaks META-INF/services (1.2.0 regression) Nov 20, 2023
@piotrp
Copy link
Author

piotrp commented Nov 20, 2023

After more testing it looks like the same issue as #490, i.e. it's broken when building on Windows

@piotrp
Copy link
Author

piotrp commented Dec 17, 2024

Maybe related to eed3si9n/jarjar-abrams#60?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant