-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editable installs now respect the value of wheel.install-dir #867
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
==========================================
+ Coverage 83.91% 83.98% +0.07%
==========================================
Files 74 74
Lines 4363 4372 +9
==========================================
+ Hits 3661 3672 +11
+ Misses 702 700 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the effort. Just some minor comments. I was looking a bit on if we have a relevant place to slot in the tests for this, but I couldn't find much, so I will help write the tests later.
…ble redirect script
FYI,
or .
Edit: this was written yesterday, I think you already fixed it. |
Signed-off-by: Cristian Le <[email protected]>
Also check that CMake is indeed re-run Signed-off-by: Cristian Le <[email protected]>
Thanks for the help in adding that error check and a test! |
Thanks for working on this! After I finish debugging pypa/cibuildwheel#1975, I'll probably try to make a release. |
Attempting to fix: #866
I'm passing down wheel.install-dir to the editable redirect script and appending it to DIR so that rebuilds happen in the correct path. This worked for me in a local testing environment, but I'm not familiar with this codebase, so I don't know if this is an optimal solution.