Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Support multi-host testing #164

Closed
engelmi opened this issue Apr 16, 2024 · 6 comments · Fixed by #169
Closed

RFE: Support multi-host testing #164

engelmi opened this issue Apr 16, 2024 · 6 comments · Fixed by #169
Labels
type: feature New feature or request

Comments

@engelmi
Copy link
Contributor

engelmi commented Apr 16, 2024

Testing Farm supports tmt's multihost testing. According to the TF multihost documentation, it is disabled by default and for enabling the pipeline type setting must be set:

{
    "settings": {
        "pipeline": {
            "type": "tmt-multihost"
        }
    }
}

Or using the testing farm CLI with --pipeline-type tmt-multihost.

As far as I've seen, it is not yet possible to pass this flag to the GitHub Action - so it would be great to add it. If this RFE is accepted, I can also start working on it and provide a PR for it.

Background:
In Eclipse BlueChi we are using the multihost testing and would like to use this GH Action. But since it doesn't support enabling multihost testing yet, we have to use the testing farm cli directly.

@zmiklank
Copy link
Collaborator

Hi, thanks for creating the issue and for your willingness to contribute :).

I see the multihost testing has a few limitations and I haven't really heard about this TF feature myself. @thrix, could you please share your opinion, if it would make sense to add such feature to TFAGA?

@thrix
Copy link
Contributor

thrix commented Apr 25, 2024

@zmiklank hi, it would be great to support setting the pipeline type in TFAGA. For now this is a previous of our new pipeline that will support multihost, in the future it will be the default one. We might be introducing this way other pipeline types, so I think supporting that field in general might be useful.

@zmiklank
Copy link
Collaborator

@zmiklank hi, it would be great to support setting the pipeline type in TFAGA. For now this is a previous of our new pipeline that will support multihost, in the future it will be the default one. We might be introducing this way other pipeline types, so I think supporting that field in general might be useful.

@thrix Thank you for the answer!

@engelmi Please feel free to start working on this if you want.

@engelmi
Copy link
Contributor Author

engelmi commented Apr 26, 2024

Sure thing :)

I already had a quick look and found that the zod schema for the testing-farm package needs to be updated. I created the PR for it (redhat-plumbers-in-action/testing-farm#112) and wait for it to be merged. After the new version is released, I continue here.

@jamacku
Copy link
Member

jamacku commented Apr 29, 2024

@engelmi
Copy link
Contributor Author

engelmi commented Apr 29, 2024

Thanks! @jamacku
Just opened a PR based on it.

@phracek phracek added the type: feature New feature or request label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants