-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/iterable chronology #21
Open
josephlarralde
wants to merge
33
commits into
master
Choose a base branch
from
feat/iterable-chronology
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added container template parameter to allow choosing between e.g. list and vector * changed container type from Events::Set<T> to Events::SetPair<T> because event sets are always picked by successive start/end pairs
base renderer doesn't deal with chronologies anymore, this has to be done by child classes it now provides minimal functionality (i.e. only combine3 method for now) and has a pure virtual method getNextSetPair which must also be implemented in child classes the orphaned endings systems has been removed because Chronology should not allow orphaned endings
* renamed nearly all impl classes/files + added new ones * updated include paths and class names wherever needed * AbstractPerformer is the base Performer class inheriting from Renderer::Provider * AbstractPerformer has a protected Renderer but doesn't implement Provider pure virtual methods * top level classes are children of AbstractPerformer : they implement Provider methods and have a Chronology
* added armed / playing / stopped internal state * added callback setter to allow listening to emitted note events * anti voice stealing is now a utility (not a strategy anymore) * added a history of anti voice stealing states to restore it anytime the index jumps * new peekNextSetPair method returning the next set pair to be rendered by render (useful for playback) * setCurrentIndex emits all pending note off events, resets all state, then sets the state to armed
…again. Crash comes from somewhere in render (combine3?)
…setChronology that caused a segfault when calling render (e.g. from the ossia binding)
* MINOR : set current index to 0 after setting chronology. Now crashes again. Crash comes from somewhere in render (combine3?) * Fixed non-initialization of local performer state in case of call to setChronology that caused a segfault when calling render (e.g. from the ossia binding)
We need to update the avs from avsHistory in two cases : * we just looped, which means currentIndex == minIndex * we moved the cursor manually and called setCurrentIndex, which means we are in Armed state
The "memory" and "functional" headers were used (for std::shared_ptr and std::function respectively) but not included. This could break the build in some environments. It has been fixed.
As per issue #24
These are NOT allNoteOffs as returned by AVS ; they do not include note offs for notes whose expected duration continues beyond the current index. Instead, the method simulates releasing all keys ; however, it does not in fact clear the pendingEndingSets map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change :