-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Seam workspace scope #461
Comments
@DebbieAtSeam do you have a recommendation here? |
@razor-x Is SeamWorkspace-Id the actual param name? I'm asking because this topic uses different param names. Is this topic out of date? Either way, I'd suggest adding a child bullet of PAT in the auth methods that has a set of possible strings. Must also include Can also include Must omit |
|
@razor-x so is the aforementioned topic incorrect? |
I doubled checked and |
Thanks, @razor-x! Here's my suggestion... Authentication Methods
We should doc the possible header params somewhere too and then link from |
I would change "Can also include The message is a bit more subtle though. First, if we say "
|
So if you feel strongly about including "optionally," that's fine, but "can" implies that it's optional, and "also" implies that it must accompany using a PAT.
OK, then how about this?
Can the generator handle generating different versions of this text for the HTTP API ref and the various SDK refs?
The case modeled above
When we get to the point where we're thinking about generating SDK refs, we'll need to figure out how to handle this difference for the SDKs vs. HTTP API. Ideally, this explanation would replace the "Must omit..." text
Again, this explanation should replace the "Can" and "Must include" strings in the SDK refs for the legacy SDKs.
No text needed here, right? |
Ok, let's just focus on the http header case then for now. I agree this falls more into the general problem of SDK / API gen differences. For the language, happy to keep the original suggestion. I just tend to personally filter out |
Now that we document each auth method, and this landed in blueprint, we can document which endpoints require a workspace ID.
From a documentation perspective, this really only affects the "Personal access token" type. I am thinking we can update this line to say something like "Personal access token with
SeamWorkspace-Id
" or "Personal access token withoutSeamWorkspace-Id
"I'm not sure the best way to communicate this though. Most endpoints require
SeamWorkspace-Id
, so it might be less noisy to indicate whenSeamWorkspace-Id
is optional or must be omitted instead. For example/workspaces/create
cannot useSeamWorkspace-Id
with /workspaces/list` can use it or not.The text was updated successfully, but these errors were encountered: