Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Velocity Portal Entry - Commands don't issue #389

Open
TreemanKing opened this issue Sep 23, 2023 · 4 comments
Open

High Velocity Portal Entry - Commands don't issue #389

TreemanKing opened this issue Sep 23, 2023 · 4 comments

Comments

@TreemanKing
Copy link
Contributor

Entering a portal at a high velocity will cause the player to first be teleported to the portal destination (end /nether), corrects itself. However, it does not issue any commands.

This can be seen by the following clip (last 10 seconds)

https://medal.tv/games/minecraft/clips/1vhfO1Wsaf0UOB/DvP9B1mzf1vo?invite=cr-MSxVUkosMjAwNDEzODc1LA

I haven't looked into any of the code yet but I'll have a look tomorrow.

@TreemanKing TreemanKing changed the title High Velocity Portal Entry High Velocity Portal Entry - Commands don't issue Sep 23, 2023
@sekwah41
Copy link
Owner

Hm ive not seen that one before, usually, they trigger. I don't have time right now but I will take a look when I can too.

@TreemanKing
Copy link
Contributor Author

Hm ive not seen that one before, usually, they trigger. I don't have time right now but I will take a look when I can too.

Just had a small look, doesn't look the there's a listener utilising the EntityEnterPortalEvent. Probably would be better to utilise this rather than EntityPortalEvent as it acts earlier.

@sekwah41
Copy link
Owner

sekwah41 commented Sep 25, 2023

There have been some changes between the events across versions as well as Paper has some extra changes, ill have to check and see which ones exist across versions supported.

@TreemanKing
Copy link
Contributor Author

TreemanKing commented Oct 4, 2023

There have been some changes between the events across versions as well as Paper has some extra changes, ill have to check and see which ones exist across versions supported.

Seems like it's supported back from 1.13 (EntityPortalEnterEvent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants