-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"when" column breaks the store #9
Comments
Same as senecajs/seneca-mysql-store#57 |
The correct escape char should be defined on the driver level and passed to this module afterwards. E.g. mysql needs to use ` instead of " or '. |
@wzrdtales please see this code: in what case is your query escaped with " or ' ? |
@mihaidma This is actually database dependend. You need to look for evey database you support. See for example MySQL http://dev.mysql.com/doc/refman/5.7/en/identifiers.html where backticks are needed to escape schema objects. |
And this given, the escape char must be defined on the driver not on this library. Otherwise this library can get useless for some new driver that has other needs which it can't pass along. |
"when" column breaks the store, needs to check if an escape is missing
senecajs/seneca-user#51
The text was updated successfully, but these errors were encountered: