Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update trade complete screen #8027

Open
3 tasks
twblack88 opened this issue Oct 29, 2024 · 2 comments · Fixed by #8240 · May be fixed by #8441
Open
3 tasks

Update trade complete screen #8027

twblack88 opened this issue Oct 29, 2024 · 2 comments · Fixed by #8240 · May be fixed by #8441
Assignees
@gomesalexandre

Comments

@twblack88
Copy link
Contributor

twblack88 commented Oct 29, 2024 •
edited
Loading

A little polish on this screen will go a long way to more volume and a better experience.

  • render a checkmark, draw the check animation by beard
  • change to trade summary (instead of show details)

new modal here

Follow on ticket
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Nov 11, 2024
@0xean
Copy link
Contributor

0xean commented Nov 11, 2024

@reallybeard will make the animated check

@NeOMakinG NeOMakinG moved this from Up next / groomed to In progress in ShapeShift Dashboard Dec 2, 2024
@NeOMakinG NeOMakinG self-assigned this Dec 2, 2024
@NeOMakinG NeOMakinG mentioned this issue Dec 2, 2024
Merged
1 task
@NeOMakinG NeOMakinG moved this from In progress to In review in ShapeShift Dashboard Dec 2, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Dec 3, 2024
@NeOMakinG
Copy link
Collaborator

We need to get it back, it's been removed with the new trade flow, make it great again with it!

@NeOMakinG NeOMakinG reopened this Dec 19, 2024
@github-project-automation github-project-automation bot moved this from Done to Up next / groomed in ShapeShift Dashboard Dec 19, 2024
@NeOMakinG NeOMakinG removed their assignment Dec 19, 2024
@gomesalexandre gomesalexandre self-assigned this Dec 24, 2024
@gomesalexandre gomesalexandre moved this from Up next / groomed to In progress in ShapeShift Dashboard Dec 24, 2024
@gomesalexandre gomesalexandre linked a pull request Dec 24, 2024 that will close this issue
Open
1 task
@gomesalexandre gomesalexandre moved this from In progress to In review in ShapeShift Dashboard Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

Labels
None yet
Projects
ShapeShift Dashboard
Status: In review
Milestone
No milestone
4 participants
@twblack88 @NeOMakinG @0xean @gomesalexandre