ajayss - User may have his transfer failed when paying price for review

[sherlock-admin3]

ajayss

Medium

User may have his transfer failed when paying price for review

Summary

In EthosReview.sol

        IERC20(paymentToken).transferFrom(msg.sender, address(this), price);

is used,
but safeTransfer is better as it checks the return values and makes sure its executed

Root Cause

using transferFrom instead of safeTransferFrom

Here

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

transfer might fail particularly where some tokens don't allow 0 price transfers, and tokens which may fail and return false.

PoC

No response

Mitigation

use safeTransferFrom to remediate this issue.