stuart_the_minion - Missing Pausing/Unpausing functionality in GoodDollarExpansionController

[sherlock-admin3]

stuart_the_minion

Medium

Missing Pausing/Unpausing functionality in GoodDollarExpansionController

Summary

Pausing/Unpausing functionality is missing in GoodDollarExpansionController.

Root Cause

The GoodDollarExpansionController inherits PausableUpgradeable contract, however, the pausing/unpausing functionalities are not implemented in GoodDollarExpansionController.

contract GoodDollarExpansionController is IGoodDollarExpansionController, PausableUpgradeable, OwnableUpgradeable {
  ... ...
}

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

PoC

No response

Mitigation

• If missing pausing/unpausing functionality is what intended, then just remove the inheritance of PausableUpgradeable contract.
• But, if it is required in the GoodDollarExpansionController contract, add pause() and unpause() as external functions, and add whenNotPaused modifier to the proper external & public functions.