-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flathub Distribution #323
Comments
I would agree. Also, distributing via packagecloud is expensive as @shiftkey has already stated. |
I'm working actively on that here: https://github.com/dnohales/com.github.Desktop Right now it builds but it doesn't run, it's also missing a desktop entry, AppData, icon, which I plan to get it done once I get it ran stably and see what has to be added in the repo itself. Once that's done we can request an App submission to Flathub. Of course if @shiftkey and GitHub team agree with that. |
is there a update on this, I would like to work on it if there has been no progress? |
Hello @AdvaithM, sorry, sadly I stopped working on this, I had a successful build but I wasn't able to run it, I was getting inspired by the VSCode Flatpak code, feel free to test and fork my repo, if you do more progress I'll remove mine to avoid confusion. |
Sure I'll take a shot and see if I can get further |
I've got a working build and the app to runs, oauth is never received mostly due to permissions. I'm not to sure how to fix it but I'll keep looking into it |
Do you have any updates on this? It would be great if we can have a flatpak package :) |
not really sure how to fix the sign in stuff. it would be pretty helpful if someone could explain how the sign in stuff worked and how I could debug this |
also the latest commits break offline building, someone with a lot more knowledge in js should probably take a shot at this. |
@shiftkey is node-detect-arm64-translation a hard dep on linux or would it be possible to remove the dep via a patch? asking since currently its very problematic with offline builds |
so looking through the package.json it isn't listed as an explicit dependency, I'm not really sure which package pulls it in |
@AdvaithM I think it's in Line 29 in ec3ed2c
Patching that out might also require patching this function: desktop/app/src/lib/get-architecture.ts Lines 1 to 21 in ec3ed2c
|
I believe for now we can just check the other arches and assume we aren't running under a translation layer |
new issue @shiftkey dugit doesn't seem to respect the cache dir env var
no idea why but it seems to work now. |
I couldn't spot anything obviously wrong with what's currently there. Here's the place where we validate the temp file, and either unpack the valid archive, or remove and try to download it again: And here's where we derive My guess is that the cached file didn't match what was expected, so it proceeded to try and download the latest version. |
currently I have a hack patch that removes |
@shiftkey, I have a working build now, but when you try and login in it just infinitely loads. console gives me this out put |
Let's move this discussion to desktop/node-detect-arm64-translation#1 as there's some context with how the package is being used that might make this different to
At this stage it seems like the app is trying to start the OAuth flow and open the browser - not sure if flatpack has restrictions on programs launching the browser but that button is initiating this flow (based on the desktop/app/src/lib/stores/sign-in-store.ts Lines 458 to 488 in 1823807
The next step from that is to invoke the browser, which is this bit: Lines 25 to 35 in 1823807
I'm curious if Flatpak has restrictions on apps launching |
I'm not to sure why this doesn't work. I'll need to look into it |
As a quick note, I gave it a short try too a while ago: https://github.com/Croydon/com.github.Desktop For me, it worked that GitHub Desktop is opening the authorization page on GitHub in my browser, but after authorizing it did not successfully redirect me back for some reason that I don't know (I also don't have any logs for potential errors unfortunately). The mime types are in the .desktop file, not sure if this is supposed to be enough https://github.com/Croydon/com.github.Desktop/blob/7166b4091f0a09dac60c45fd848ff0246b6c2d1f/com.github.Desktop.desktop#L9 The end result is that the app ultimately can't login. |
running this on a system without github-desktop installed before had it works, I'm not sure why. maybe uninstalling github-desktop doesn't remove all of the files? |
opening a new issue to track what works, and possible fixes. |
@AdvaithM @shiftkey I think it is better to add it as If it is getting added as What do you think? |
Flathub wanted the name to be changed to show it's a fork flathub/flathub#2417 (comment) |
Yes, because you have downloaded the source directly from this fork. If you would first download the official source code and then apply the changes in this fork as a patch we can work around that and still fulfill all conventions and rules I guess. |
it would create a massive unmaintainable patch not worth the cost of maintenance in the slightest. flatpak does have ways to e-o-l one app and point to a replacement. we could also just change the name during an update if upstream does deiced to support linux. Another issue is that this repo contains many files not present upstream which would make it even more difficult to maintain the patch. Every single file not present upstream would have to be created before the patch is applied which is would be very difficult to do constantly. It is hard to maintain patches/patch sets which is why as maintainers of downstream distributions we try and upstream as much as possible. I personally do not see a patch set based on this repo being without missing releases by weeks or even months. |
This can be closed now, github desktop in now on flathub https://github.com/flathub/io.github.shiftey.Desktop. |
Describe the feature or problem you’d like to solve
While having solutions for multiple linux distributions is great, and AppImages also being offered, I'd like to have a Flatpak version offered via Flathub aswell. They integrate more seamlessly into the system and are easy to update out-of-the-box.
Proposed solution
Making the software available on Flathub for easy access, you don't even need to know about this repository at all, to find it. Without digging through the internet I wouldn't even have found this repository since it's nowhere mentioned on the official Github Desktop download page.
Additional context
-/-
The text was updated successfully, but these errors were encountered: