[BUG] v1alpha1 Build Strategies with builder-image parameters fail

[adambkaplan]

Is there an existing issue for this?

• I have searched the existing issues

Kubernetes Version

1.27

Shipwright Version

v0.12.0

Current Behavior

If a build strategy is created using the v1alpha1 API and includes a parameter with the name builder-image, its value is not set correctly if the Build or BuildRun uses paramValues to set the parameter value.

Expected Behavior

Builds should succeed if the builder-image parameter is declared in the build strategy, even for v1alpha1 APIs. The conversion webhook should not overwrite values if they are present.

Steps To Reproduce

1. Create a ClusterBuildStrategy that uses the v1alpha1 API and a builder-image parameter

   apiVersion: shipwright.io/v1alpha1
   kind: ClusterBuildStrategy
   metadata:
      name: source-to-image
   spec:
      ...
      parameters:
         - name: builder-image
           description: Builder image for this build strategy

2. Create a Build that utilizes the build strategy: $ shp build create s2i-ex --strategy source-to-image ...

3. Start a build referencing this strategy: $ shp build run s2i-ex

Anything else?

Work-around is to use a parameter name that is not builder-image.

For example, source-to-image build strategies can use the s2i-builder-image parameter.

Root issue likely due to the fact we are using "magic parameters" to translate fields that were deprecated in v1alpha1 and removed in v1beta1. I suspect we'll see a similar bug with the dockerfile parameter.

https://github.com/shipwright-io/build/blob/main/pkg/apis/build/v1beta1/build_conversion.go#L167-L186

[qu1queee]

From Refinement, @SaschaSchwarze0 @qu1queee , pls take a look.

[adambkaplan]

Note - we should consider this bug obsolete when we stop supporting the v1alpha1 API.