Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add Stream Handling - Never Write if nothing got Readed #2

Open
frank-dspeed opened this issue Dec 11, 2018 · 3 comments
Open

PR: Add Stream Handling - Never Write if nothing got Readed #2

frank-dspeed opened this issue Dec 11, 2018 · 3 comments

Comments

@frank-dspeed
Copy link

In any case, the file will be accessed and it's contents may be overwritten even if there's no actual read operation done (due to node.js streams buffering mechanisms).

@frank-dspeed
Copy link
Author

Will add the Parts with some Observable FRP Sugar ;)

@MichalCz
Copy link
Member

Hmm... That shouldn't happen. The write location should not exceed read location. You mean the buffer of the piped stream?

@MichalCz
Copy link
Member

Please make sure to write a test in the first commit to show the issue. I think I see what you mean, but even if that's confirmed and fixed at done pointit will reoccur without a proper test. :)

Anyway your PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants