Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extraVolumeMounts to allow custom TLS verification for fulcio deployments #872

Open
sparikh205 opened this issue Dec 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sparikh205
Copy link

Description

Hey, I am using the fulcio helm charts as a dependency in my current implementation. Encountered a limitation when trying to include additional volume mounts. The issue originated with a TLS issue when using keycloak as an OIDC provider, because it was signed by an internal CA. The current chart does not seem to provide a way to set a CA to use for TLS verification, which is essential for my use case.

Is this just something we missed in the implementation?

If we did not miss something we would make the following Proposal:
I suggest modifying the chart to include parameters for custom volume mounts. This can be achieved by adding fields to the values.yaml file and updating the deployment templates and README.md accordingly.

Potential code changes:

  • Include helm templating lines:
{{- if .Values.extraVolumeMounts }} 
    {{- toYaml .Values.extraVolumeMounts | nindent 10 }}
{{- end }}

Additonal resources:

@sparikh205 sparikh205 added the enhancement New feature or request label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant