Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for handling of malleable fields #151

Open
woodruffw opened this issue Aug 16, 2024 · 2 comments
Open

Tests for handling of malleable fields #151

woodruffw opened this issue Aug 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@woodruffw
Copy link
Member

@segiddins has pointed out that some Rekor log entry/bundle fields have malleable formats, e.g. anything that uses Base64 (or PEM). We should probably have some tests that confirm that clients perform comparisons on the underlying contents, not the malleable containers themselves.

@woodruffw woodruffw added the enhancement New feature or request label Aug 16, 2024
@haydentherapper
Copy link
Collaborator

I have a doc about this topic I can share. Ideally we solve this in Rekor by canonicalizing to a specific format, but it’s a hard problem just due to how many transformations are possible.

From a client perspective, they should verify using the canonicalized structure returned by the log.

From a monitor perspective, the risk is low, just that someone could reupload a malleable entry.

@woodruffw
Copy link
Member Author

Thanks @haydentherapper! Yeah, I agree the risk is low here -- I think having these will help prevent more false negatives in clients (e.g. around slightly different PEM serializations) than anything else 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants