Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug, In the removal did process, not remove data in table sms_dids. #15

Open
vsc55 opened this issue Apr 9, 2023 · 2 comments
Open

Comments

@vsc55
Copy link
Contributor

vsc55 commented Apr 9, 2023

Fix en #14

I have created a ticket in FreePBX to see if they implement a function and that is how it is called and problems are avoided.
https://issues.freepbx.org/browse/FREEPBX-24126

@billsimon
Copy link
Contributor

I do not believe this to be a bug but rather by design.

By keeping DIDs in the sms_did table, the didid is maintained and this key is used in sms_messages.

You can then remove DID routing and reassign and the messages that are stored in the database are still correctly associated with the DID.

That's how I see it, but there is no documentation on the SMS module so this may be the intention of the developers or it may be a bug.

I like keeping the DIDs in the sms_did table and am hesitant to change this behavior unless FreePBX developers change it in SMS module.

@vsc55
Copy link
Contributor Author

vsc55 commented Apr 13, 2023

Hi @billsimon,
Ok, I see your point.
But I don't see the need to keep the did in the sms_dids table since the sms_messages table already shows the did in the "from" column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants