Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into dependency management code #4

Open
alikindsys opened this issue Aug 1, 2021 · 0 comments
Open

Look into dependency management code #4

alikindsys opened this issue Aug 1, 2021 · 0 comments

Comments

@alikindsys
Copy link
Member

alikindsys commented Aug 1, 2021

That code looks convoluted with probably un-needed recursion and a loop that only executes one value.

if (!innerDep.Any()) return SisbaseResult.FromSucess();
return await CheckDependencies(sys, newStack);

It also doesn't check for the intersection of already unloaded systems, although I don't believe thats much of an issue, since its likely pre-emptive optimization.

Anyways, I do believe a cleaner solution can be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant