Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File size check incomplete #4

Open
kdambekalns opened this issue Nov 18, 2022 · 0 comments · May be fixed by #6
Open

File size check incomplete #4

kdambekalns opened this issue Nov 18, 2022 · 0 comments · May be fixed by #6

Comments

@kdambekalns
Copy link

As per the comment this checks for the original or optimized files being empty:

Sitegeist.Iconoclasm/Classes/Service/ThumbnailOptimizationService.php

Line 102 in 0adc121

if ($filesizeOriginal === false || $filesizeOptimized === false) {

But the strict check only handles errors, not the file being empty… This leads to empty files being used happily:

Optimized image "…-305-7952x4473.jpg" with command "…" reduction 603.24 KB > 0.00 B bytes - reduction 100.00 %
kdambekalns added a commit to kdambekalns/Sitegeist.Iconoclasm that referenced this issue Nov 18, 2022
@kdambekalns
BUGFIX: Handle empty files correctly in check
7a4f80c 
Fixes sitegeist#4
@kdambekalns kdambekalns mentioned this issue Nov 18, 2022
Closed
kdambekalns added a commit to kdambekalns/Sitegeist.Iconoclasm that referenced this issue Nov 18, 2022
@kdambekalns
BUGFIX: Handle empty files correctly in check
6aa5888 
Fixes sitegeist#4
@kdambekalns kdambekalns linked a pull request Nov 18, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kdambekalns