From dda097242a17f76017b9220b5abecf35d1b41b10 Mon Sep 17 00:00:00 2001 From: David Spiola Date: Tue, 24 Nov 2020 16:23:55 +0100 Subject: [PATCH] BUG: fix dimensionInformatonViewHelper The render method should be declared without arguments according to the fluid core view helpers. This causes an issue while determining the root node what could potentially lead to a wrong behavior --- Classes/ViewHelpers/DimensionInformationViewHelper.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Classes/ViewHelpers/DimensionInformationViewHelper.php b/Classes/ViewHelpers/DimensionInformationViewHelper.php index 940b250..1ad887c 100644 --- a/Classes/ViewHelpers/DimensionInformationViewHelper.php +++ b/Classes/ViewHelpers/DimensionInformationViewHelper.php @@ -21,17 +21,15 @@ public function initializeArguments() } /** - * @param NodeInterface $node - * @param string $dimension dimension name * @return string value with replaced text * @api */ - public function render(NodeInterface $node, $dimension = null) + public function render() { return self::renderStatic( [ - 'node' => $node, - 'dimension' => $dimension + 'node' => $this->arguments['node'], + 'dimension' => $this->arguments['dimension'] ], $this->buildRenderChildrenClosure(), $this->renderingContext