Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] synchronize dependency checking utilities with sktime and skbase #489

Closed
fkiraly opened this issue Nov 9, 2024 · 2 comments
Closed

[ENH] synchronize dependency checking utilities with sktime and skbase #489

fkiraly opened this issue Nov 9, 2024 · 2 comments
Labels
enhancement maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Nov 9, 2024 •
edited
Loading

The dependency checking utilities in utils should be synchronized with sktime, see utils.dependencies there, and skbase.

The long-term trajectory is deduplication with single location of truth in skbase, but this will require equal functionality throughout the three packages, as an intermediate step.

Currently, the skpro module - in utils.validation._dependencies - is a fork of a much earlier version of the sktime module, and is subject to the problem that it imports the packages in order to check presence of dependencies.

This is causing the failures in the test collection phase in #358, or more generally, in a case where the imported package is faulty, with import causing exceptions (in the case of #358, arviz).

@meraldoantonio has committed to sort this out in a separate PR, this should resolve the failures in #358 as well.
@fkiraly fkiraly added enhancement maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests labels Nov 9, 2024
@fkiraly fkiraly mentioned this issue Nov 9, 2024
Merged
4 tasks
@meraldoantonio
Copy link
Contributor

The dependency checking utilities in utils should be synchronized with sktime, see utils.dependencies there, and skbase.

The long-term trajectory is deduplication with single location of truth in skbase, but this will require equal functionality throughout the three packages, as an intermediate step.

Currently, the skpro module - in utils.validation._dependencies - is a fork of a much earlier version of the sktime module, and is subject to the problem that it imports the packages in order to check presence of dependencies.

This is causing the failures in the test collection phase in #358, or more generally, in a case where the imported package is faulty, with import causing exceptions (in the case of #358, arviz).

Hi Franz, opened new PR #490

@meraldoantonio meraldoantonio mentioned this issue Nov 12, 2024
Merged
1 task
fkiraly pushed a commit that referenced this issue Nov 16, 2024
@meraldoantonio
[ENH] Synchronize dependency checker with sktime counterpart (#490)
a478466 
#### Reference Issues/PRs
Potentially fixes #358 (failing Python tests)
Addresses issue #489

#### What does this implement/fix? Explain your changes.

Synchronized dependency checking utilities in utils with the one from
`sktime`

The current version is a fork of a much earlier version of `sktime` and
is problematic as it must import packages in order to check presence of
dependencies. This is causing the failures in the test collection phase
in #358, or more generally, in a case where the imported package is
faulty, with import causing exceptions.

#### Did you add any tests for the change?
Yes, I copied the corresponding dependency test `test_show_versions`
from `sktime`
@fkiraly
Copy link
Collaborator Author

fkiraly commented Nov 16, 2024

Addressed in #490

@fkiraly fkiraly closed this as completed Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkiraly @meraldoantonio