Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Parameterize Docker image for SSL + HTTPS #469

Open
3 tasks
olemis opened this issue Sep 8, 2018 · 8 comments
Open
3 tasks

[docker] Parameterize Docker image for SSL + HTTPS #469

olemis opened this issue Sep 8, 2018 · 8 comments

Comments

@olemis
Copy link

olemis commented Sep 8, 2018

Adding SSL+HTTPS requires editing nginx.conf . Provide a way to do the same by providing a parameter to the image at run time.

  • Image entry point
  • Image CLI parameters for SSL + HTTPS
  • Option to rely on Let's Encrypt during the process
@gz-c
Copy link
Member

gz-c commented Sep 8, 2018

Is it possible to use let's encrypt for this

@olemis
Copy link
Author

olemis commented Sep 8, 2018

I guess so, should we offer the option in entry point or somehow . @stdevNorge can tell better.

@stdevYuniers
Copy link

Task Option to rely on Let's Encrypt during the process can't be done on image build because Let's Encrypts made checks when a certificate is generated. It must done on start up process or manual exec of an user.

@gz-c
Copy link
Member

gz-c commented Jan 21, 2019

@iketheadore Do you have any comment on this issue

@gz-c
Copy link
Member

gz-c commented Jan 21, 2019

I think SSL/HTTPS is handled at a different layer than inside the docker container, and is out of scope for this project

@olemis
Copy link
Author

olemis commented Jan 21, 2019

sometimes it's handled by the load balance software ... but the fact is that the Docker image is derived from nginx:alpine , so the instructions in aforementioned article (section Set up Your Production Site to Run in a Nginx Docker Container) apply.

@olemis
Copy link
Author

olemis commented Jan 21, 2019

when a single web wallet node is launched there is no load balance proxy , and SSL certificate has to be configured directly through the nginx daemon running inside the Docker container .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants