Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

que: Issue in the ListUsers and ListGroups callback functions ? #107

Open
laurentdelosieresfact opened this issue May 11, 2023 · 3 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@laurentdelosieresfact
Copy link

laurentdelosieresfact commented May 11, 2023

Hello,

We have been investigating this issue. When Google is facing some problems, the list of groups returned is incomplete and the idp-scim-sync deletes the group on the AWS side. In other words, the users are losing access to our AWS infra :(

We think that this is related to the callback functions (see here and here). According to google-api-go-client code, "Pages invokes f for each page of results. A non-nil error returned from f will halt the iteration." As you can see in the body of the callback functions, we always return nil, so we never stop the iteration upon receiving an error, which might cause an inconsistency 🤔

Best,
L.

@laurentdelosieresfact laurentdelosieresfact added the question Further information is requested label May 11, 2023
@laurentdelosieresfact laurentdelosieresfact changed the title que: Issue in the ListUsers and ListGroups functions ? que: Issue in the ListUsers and ListGroups callback functions ? May 11, 2023
@christiangda
Copy link
Contributor

hi @laurentdelosieresfact thank you very much for your analysis, I will check it in deep to try to fix the problem we are experimenting with the deletion of groups because the Google side fails.

christiangda added a commit that referenced this issue May 14, 2023
@christiangda christiangda self-assigned this May 14, 2023
@christiangda christiangda added this to the v0.0.18 milestone May 14, 2023
@christiangda
Copy link
Contributor

@laurentdelosieresfact my PR will probably fix the issue you describe here, the problem I have is how to test it, I was trying to mock the release Google API but it is challenging because of the chaining of different methods and data structures.

I will try again with a different strategy to ensure that when the Pages method fails, propagate the error upstream.

@laurentdelosieresfact
Copy link
Author

laurentdelosieresfact commented May 15, 2023

Hi @christiangda ,

We have been running the PR for over 2 months and we have not experienced any issues. No groups being randomly deleted 👍 Can you please merge the PR with the changes 🙏

Best,
L.

github-merge-queue bot pushed a commit that referenced this issue Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants