Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation related to DFG Viewer #330

Open
stweil opened this issue Dec 14, 2024 · 1 comment
Open

Documentation related to DFG Viewer #330

stweil opened this issue Dec 14, 2024 · 1 comment
Assignees
Labels
❔ question A non-code issue or question.

Comments

@stweil
Copy link
Contributor

stweil commented Dec 14, 2024

This issue is related to documentation which is offered by https://dfg-viewer.de/, but not part of the GitHub repository.

While reading the documentation, I noticed a number of issues and inconsistencies.

Example:

In SRU-ALTO-Anwendungsprofil_1.0.pdf there is a mismatch between the description for dv:page (3 attributes: id, width, height) and the example (4 attributes: id, width, height, url). And there are typos like Elememente and several more.

It would be nice to have a repository for the documentation where issues and pull requests can be contributed.

@stweil
Copy link
Contributor Author

stweil commented Dec 14, 2024

@sebastian-meyer, I read the profile documentations because I tried to implement an SRU server. Are there any examples which work with the DFG Viewer? Meanwhile I managed to get a connection after debugging the code (see note). The special case with no search results also works, but if my server returns one or more results, nothing is shown in the viewer.

Update: results are shown if the SRU server uses the prefix "srw:" for all SRU tags. This should be fixed in the code, because the standard has no such requirement. Valid XML can have any prefix or no prefix at all.

@beatrycze-volk beatrycze-volk added the ❔ question A non-code issue or question. label Dec 17, 2024
@beatrycze-volk beatrycze-volk added this to the DFG-Viewer 6.2.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❔ question A non-code issue or question.
Projects
None yet
Development

No branches or pull requests

3 participants