Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship 3971 update sentinel #1522

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Ship 3971 update sentinel #1522

merged 4 commits into from
Jan 6, 2025

Conversation

davidcauchi
Copy link
Contributor

@davidcauchi davidcauchi commented Jan 6, 2025

  • Adds Sentinel Coordinator struct
  • Minor adjustment to sentinel logging

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes streamline logging for subscription management in the Sentinel application and introduce a new SentinelCoordinator struct to manage Sentinel instances. These improvements enhance the application's structure and debuggability.

What

  • sentinel/.changeset/v0.1.1.md
    • Adds a new changeset markdown file indicating the addition of SentinelCoordinator struct and a minor logging fix.
  • sentinel/internal/subscription_manager/subscription_manager.go
    • Changes logging from Hex to Str for address and topic in Subscribe, Unsubscribe, and BroadcastLog methods to simplify reading logs.
  • sentinel/sentinel_coordinator.go
    • Adds a new file defining the SentinelCoordinator struct with fields for managing a Sentinel instance, synchronization, context for lifecycle management, and logging. Also includes a constructor function NewSentinelCoordinator.

@cl-sonarqube-production
Copy link

@davidcauchi davidcauchi merged commit 15722ca into main Jan 6, 2025
49 of 51 checks passed
@davidcauchi davidcauchi deleted the ship-3971-update-sentinel branch January 6, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants