Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP #3: Make the tokens edible #4

Open
smartcontracts opened this issue Aug 28, 2021 · 10 comments
Open

SIP #3: Make the tokens edible #4

smartcontracts opened this issue Aug 28, 2021 · 10 comments

Comments

@smartcontracts
Copy link
Owner

Make the tokens edible

By Mitchfinn

Well if anyone can decipher what this means then we'll implement it.

@qbzzt
Copy link

qbzzt commented Aug 28, 2021

In addition to function transfer(address _to, uint256 _amount), which lets you transfer tokens, have function feed(address _to, uint256 _amount). This function can have several results, chosen as randomly as possible next time the recipient attempts to transfer tokens.

  1. Normal, no special effects.
  2. Diarrhea, the next time the recipient attempts a transfer, it ends up being up to five times more than the intended amount.
  3. Constipation, any transfers by the recipient for the next 24 hours fail.

@smartcontracts
Copy link
Owner Author

@qbzzt wow that is so good. Do you think you can make a pull request with that behavior

@smartcontracts
Copy link
Owner Author

I'd like to have a "good" option so it's like gambling on whether or not to feed the contract

@JTraversa
Copy link
Contributor

JTraversa commented Aug 28, 2021

I think a euphemism around the ability to tell others to eat shit is the way to go here.

E.g. Allow one user to tell another to eat shit by allowing them to burn a proportional amount of their own tokens and their chosen user.

  function eatShit(address to, uint256 courics) public returns (bool) {
      require(to != address(0));
      
      _burn(to, courics);
      _burn(msg.sender, courics);
      
      return (true);
  }

@qbzzt
Copy link

qbzzt commented Aug 28, 2021

@qbzzt wow that is so good. Do you think you can make a pull request with that behavior

I'll do it, but it might take me a while (life's slightly busy)

zac-williamson added a commit to zac-williamson/shitdao that referenced this issue Aug 28, 2021
Implements SIP 3 (Issue smartcontracts#4), giving users the ability to feed each other.
@zac-williamson
Copy link
Contributor

@qbzzt I hope you don't mind me taking the liberty of implementing this.

I also added a positive outcome per @smartcontracts request. Feeding a user has a 25% chance of adding an additional 1 token to their balance.

@qbzzt
Copy link

qbzzt commented Aug 28, 2021 via email

@zac-williamson
Copy link
Contributor

Mind? I prefer that. Life is a bit hectic. Anyway, what do you mean by one token? The equivalent of one wei? That is tiny, how about we multiply the balance by 1.25 instead?

On Sat, Aug 28, 2021, 1:31 PM Zachary James Williamson < @.***> wrote: @qbzzt https://github.com/qbzzt I hope you don't mind me taking the liberty of implementing this. I also added a positive outcome per @smartcontracts https://github.com/smartcontracts request. Feeding a user has a 25% chance of adding an additional 1 token to their balance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBCGGOOELQFIRUWKOAN66LT7ETRVANCNFSM5C6TXPRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Aye 1 token is tiny. Thing is nothing onchain is truly random - if the balance was multiplied by 1.25 this would allow a user to arbitrarily increase their balance.

Although given this is shitDAO maybe that doesn't matter...

@qbzzt
Copy link

qbzzt commented Aug 28, 2021 via email

@zac-williamson
Copy link
Contributor

Change the 25% from a minting to a transfer from the feeder. Then the abuse doesn't matter. If you're going to feed anybody shit, don't be surprised if there is a bad consequence to you too On Sat, Aug 28, 2021, 5:21 PM Zachary James Williamson < @.> wrote:

Mind? I prefer that. Life is a bit hectic. Anyway, what do you mean by one token? The equivalent of one wei? That is tiny, how about we multiply the balance by 1.25 instead? … <#m_2102270948825513548_> On Sat, Aug 28, 2021, 1:31 PM Zachary James Williamson < @.
> wrote: @qbzzt https://github.com/qbzzt https://github.com/qbzzt I hope you don't mind me taking the liberty of implementing this. I also added a positive outcome per @smartcontracts https://github.com/smartcontracts https://github.com/smartcontracts request. Feeding a user has a 25% chance of adding an additional 1 token to their balance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment) <#4 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBCGGOOELQFIRUWKOAN66LT7ETRVANCNFSM5C6TXPRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . Aye 1 token is tiny. Thing is nothing onchain is truly random - if the balance was multiplied by 1.25 this would allow a user to arbitrarily increase their balance. Although given this is shitDAO maybe that doesn't matter... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBCGGOOPIWGON7I4VNYQ7LT7FOOJANCNFSM5C6TXPRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Sounds good to me. Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants