date_format

[totalAldo]

Since date_format is a wrapper to strftime(), will this be updated for PHP8.1+ compatiblity?

[totalAldo]

sorry, just reviewed the code and see that it uses date() when formatter is auto and % characters are not used.

[totalAldo]

After further review, while date() is supported, it requires using the parameters that date() expects. This leaves any existing code that utilizes %x modifiers in the date_format string as deprecated. Does it make sense to add a wrapper to map the strftime() modifiers to date() modifiers?

Additionally, the html_select_date plugin also currently uses strftime() and thus throws deprecated errors in php 8.1

[totalAldo]

Here is an incomplete shim for date() which maps accepted parameters from stftime(). I'm not sure if this is the right direction to take since some of the format strings don't map exactly to date() parameters. Welcome feedback and thoughts
modifier.date_format.php.txt

Relevant code:

        // apply shim from strftime() to date() for PHP 8.1+
        if (PHP_VERSION_ID >= 80100) {
            // https://www.php.net/manual/en/function.strftime.php
            $_strftime_format = array(
                '%a', //	An abbreviated textual representation of the day	Sun through Sat
                '%A', //	A full textual representation of the day	Sunday through Saturday
                '%d', //    Two-digit day of the month (with leading zeros)	01 to 31
                '%e', //	Day of the month, with a space preceding single digits. Not implemented as described on Windows. See below for more information.	1 to 31
                '%j', //	Day of the year, 3 digits with leading zeros	001 to 366
                '%u', //	ISO-8601 numeric representation of the day of the week	1 (for Monday) through 7 (for Sunday)
                '%w', //	Numeric representation of the day of the week	0 (for Sunday) through 6 (for Saturday)
                // Week	---	---
                '%U', //	Week number of the given year, starting with the first Sunday as the first week	13 (for the 13th full week of the year)
                '%V', //	ISO-8601:1988 week number of the given year, starting with the first week of the year with at least 4 weekdays, with Monday being the start of the week	01 through 53 (where 53 accounts for an overlapping week)
                '%W', //	A numeric representation of the week of the year, starting with the first Monday as the first week	46 (for the 46th week of the year beginning with a Monday)
                // Month	---	---
                '%b', //	Abbreviated month name, based on the locale	Jan through Dec
                '%B', //	Full month name, based on the locale	January through December
                '%h', //	Abbreviated month name, based on the locale (an alias of %b)	Jan through Dec
                '%m', //	Two digit representation of the month	01 (for January) through 12 (for December)
                // Year	---	---
                '%C', //	Two digit representation of the century (year divided by 100, truncated to an integer)	19 for the 20th Century
                '%g', //	Two digit representation of the year going by ISO-8601:1988 standards (see %V)	Example: 09 for the week of January 6, 2009
                '%G', //	The full four-digit version of %g	Example: 2008 for the week of January 3, 2009
                '%y', //	Two digit representation of the year	Example: 09 for 2009, 79 for 1979
                '%Y', //	Four digit representation for the year	Example: 2038
                // Time	---	---
                '%H', //	Two digit representation of the hour in 24-hour format	00 through 23
                '%k', //	Hour in 24-hour format, with a space preceding single digits	0 through 23
                '%I', //	Two digit representation of the hour in 12-hour format	01 through 12
                '%l', //    (lower-case 'L')	Hour in 12-hour format, with a space preceding single digits	1 through 12
                '%M', //    Two digit representation of the minute	00 through 59
                '%p', //	UPPER-CASE 'AM' or 'PM' based on the given time	Example: AM for 00:31, PM for 22:23
                '%P', //	lower-case 'am' or 'pm' based on the given time	Example: am for 00:31, pm for 22:23
                '%r', //	Same as "%I:%M:%S %p"	Example: 09:34:17 PM for 21:34:17
                '%R', //	Same as "%H:%M"	Example: 00:35 for 12:35 AM, 16:44 for 4:44 PM
                '%S', //	Two digit representation of the second	00 through 59
                '%T', //	Same as "%H:%M:%S"	Example: 21:34:17 for 09:34:17 PM
                '%X', //	Preferred time representation based on locale, without the date	Example: 03:59:16 or 15:59:16
                '%z', //	The time zone offset. Not implemented as described on Windows. See below for more information.	Example: -0500 for US Eastern Time
                '%Z', //	The time zone abbreviation. Not implemented as described on Windows. See below for more information.	Example: EST for Eastern Time
                // Time and Date Stamps	---	---
                '%c', //	Preferred date and time stamp based on locale	Example: Tue Feb 5 00:45:10 2009 for February 5, 2009 at 12:45:10 AM
                '%D', //	Same as "%m/%d/%y"	Example: 02/05/09 for February 5, 2009
                '%F', //	Same as "%Y-%m-%d" (commonly used in database datestamps)	Example: 2009-02-05 for February 5, 2009
                '%s', //	Unix Epoch Time timestamp (same as the time() function)	Example: 305815200 for September 10, 1979 08:40:00 AM
                '%x', //	Preferred date representation based on locale, without the time	Example: 02/05/09 for February 5, 2009
                // Miscellaneous	---	---
                '%n', //	A newline character ("\n")	---
                '%t', //	A Tab character ("\t")	---
                '%%', //	A literal percentage character ("%")	---
            );

            // https://www.php.net/manual/en/datetime.format.php
            // Missing shim for century prefix.
            // Some of the starting week positions don't match those of strftime().
            // locale date displayed in US format m/d/Y
            $_date_format = array(
                // Day	---	---
                'D', //     A textual representation of a day, three letters	Mon through Sun
                'l', //     (lowercase 'L')	A full textual representation of the day of the week	Sunday through Saturday
                'd', //	    Day of the month, 2 digits with leading zeros	01 to 31
                'j', // 	Day of the month without leading zeros	1 to 31
                'z', // 	The day of the year (starting from 0)	0 through 365
                'N', // 	ISO 8601 numeric representation of the day of the week	1 (for Monday) through 7 (for Sunday)
                'w', // 	Numeric representation of the day of the week	0 (for Sunday) through 6 (for Saturday)
                // Week	---	---
                'W', // 	ISO 8601 week number of year, weeks starting on Monday	Example: 42 (the 42nd week in the year)
                'W', //     ISO 8601 week number of year, weeks starting on Monday	Example: 42 (the 42nd week in the year)
                'W', //     ISO 8601 week number of year, weeks starting on Monday	Example: 42 (the 42nd week in the year)
                // Month --- ---
                'M', // 	A short textual representation of a month, three letters	Jan through Dec
                'F', //     A full textual representation of a month, such as January or March	January through December
                'M', // 	A short textual representation of a month, three letters	Jan through Dec
                'm', // 	Numeric representation of a month, with leading zeros	01 through 12
                // Year	---	---
                '',  //     century not implemented in date(), can be substr(date("Y", 0, 2))
                'y', // 	A two digit representation of a year	Examples: 99 or 03
                'o', // 	ISO 8601 week-numbering year. This has the same value as Y, except that if the ISO week number (W) belongs to the previous or next year, that year is used instead.	Examples: 1999 or 2003
                'y', // 	A two digit representation of a year	Examples: 99 or 03
                'Y', //	    A full numeric representation of a year, 4 digits	Examples: 1999 or 2003
                // Time	---	---
                'H', // 	24-hour format of an hour with leading zeros	00 through 23
                'G', // 	24-hour format of an hour without leading zeros	0 through 23
                'h', // 	12-hour format of an hour with leading zeros	01 through 12
                'g', // 	12-hour format of an hour without leading zeros	1 through 12
                'i', // 	Minutes with leading zeros	00 to 59
                'A', // 	Uppercase Ante meridiem and Post meridiem	AM or PM
                'a', // 	Lowercase Ante meridiem and Post meridiem	am or pm
                'h:i:s A', // Example: 09:34:17 PM for 21:34:17
                'H:i', //   Example: 00:35 for 12:35 AM, 16:44 for 4:44 PM
                's', // 	Seconds with leading zeros	00 through 59
                'H:i:s', // Example: 21:34:17 for 09:34:17 PM
                'H:i:s', // Preferred time representation based on locale, without the date	Example: 03:59:16 or 15:59:16
                'O', // 	Difference to Greenwich time (GMT) without colon between hours and minutes	Example: +0200
                'T', // 	Timezone abbreviation, if known; otherwise the GMT offset.	Examples: EST, MDT, +05
                // Time and Date Stamps	---	---
                'r',	//      RFC 2822 formatted date	Example: Thu, 21 Dec 2000 16:01:07 +0200
                'm/d/Y', //	Same as "%m/%d/%y"	Example: 02/05/09 for February 5, 2009
                'Y-m-d', //	Same as "%Y-%m-%d" (commonly used in database datestamps)	Example: 2009-02-05 for February 5, 2009
                'U', // 	Seconds since the Unix Epoch (January 1 1970 00:00:00 GMT)	See also time()
                'm/d/Y', //	Preferred date representation based on locale, without the time	Example: 02/05/09 for February 5, 2009
                // Miscellaneous	---	---
                '\\n', //	A newline character ("\n")	---
                '\\t', //	A Tab character ("\t")	---
                '%', //	A literal percentage character ("%")	---

                // -- Unmapped formats that exist in date() but not strftime()
                // S	English ordinal suffix for the day of the month, 2 characters	st, nd, rd or th. Works well with j
                // n	Numeric representation of a month, without leading zeros	1 through 12
                // t	Number of days in the given month	28 through 31
                // Year	---	---
                // L	Whether it's a leap year	1 if it is a leap year, 0 otherwise.
                // Time	---	---
                // B	Swatch Internet time	000 through 999
                // u	Microseconds. Note that date() will always generate 000000 since it takes an int parameter, whereas DateTime::format() does support microseconds if DateTime was created with microseconds.	Example: 654321
                // v	Milliseconds. Same note applies as for u.	Example: 654
                // Timezone	---	---
                // e	Timezone identifier	Examples: UTC, GMT, Atlantic/Azores
                // I (capital i)	Whether or not the date is in daylight saving time	1 if Daylight Saving Time, 0 otherwise.
                // P	Difference to Greenwich time (GMT) with colon between hours and minutes	Example: +02:00
                // p	The same as P, but returns Z instead of +00:00 (available as of PHP 8.0.0)	Example: +02:00
                // Z	Timezone offset in seconds. The offset for timezones west of UTC is always negative, and for those east of UTC is always positive.	-43200 through 50400
                // Full Date/Time	---	---
                // c	ISO 8601 date	2004-02-12T15:19:21+00:00
            );

            $format = str_replace($_strftime_format, $_date_format, $format);

            return date($format, $timestamp);
        } else {
            return strftime($format, $timestamp);
        }

[wisskid]

Hi @totalAldo! There is much discussion going on on this topic already: https://github.com/smarty-php/smarty/search?q=strftime&type=issues

[totalAldo]

thanks @wisskid! I didn't know best place to discuss this as its both a question and potential solution. If you'd like me to add this to an existing issues thread, please point me in the right direction.

[wisskid]

I did, just follow the link :)