feat: add members space page #971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feat-960-add-members-space-page
bonustrack
reviewed
Nov 7, 2024
Co-authored-by: Less <[email protected]>
|
@Sekhmet can you review this PR? |
Sekhmet
reviewed
Nov 27, 2024
Co-authored-by: Wiktor Tkaczyński <[email protected]>
Co-authored-by: Wiktor Tkaczyński <[email protected]>
… into feat-960-add-members-space-page
Sekhmet
reviewed
Dec 6, 2024
|
@Sekhmet Fixed. Could you approve? |
Sekhmet
reviewed
Dec 17, 2024
Comment on lines
+371
to
+376
| statements(where: $statementsWhere) { | ||
| delegate | ||
| space | ||
| network | ||
| statement | ||
| } |
There was a problem hiding this comment.
Maybe as a precaution let's fetch 100 statements there, should be enough to cover members of most spaces, afraid that default (20) might not be always enough.
first arg controls how many we fetch.
Sekhmet
reviewed
Dec 17, 2024
Comment on lines
+788
to
+798
| const { data } = await apollo.query({ | ||
| query: STATEMENTS_AND_USERS_QUERY, | ||
| variables: { | ||
| where: { | ||
| delegate_in: userIds, | ||
| network: networkId, | ||
| space: spaceId | ||
| }, | ||
| userIds | ||
| } | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const { data } = await apollo.query({ | |
| query: STATEMENTS_AND_USERS_QUERY, | |
| variables: { | |
| where: { | |
| delegate_in: userIds, | |
| network: networkId, | |
| space: spaceId | |
| }, | |
| userIds | |
| } | |
| }); | |
| const { data } = await apollo.query({ | |
| query: STATEMENTS_AND_USERS_QUERY, | |
| variables: { | |
| statementsWhere: { | |
| delegate_in: userIds, | |
| network: networkId, | |
| space: spaceId | |
| }, | |
| userIds | |
| } | |
| }); |
Right now we are not filtering statements at all because argument name doesn't match, so we just fetch random 20 statements that are most likely not for the members of the space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new space page and item in the space menu called "Members".
Closes: #960
How to test
Membersnavigation item is visibleMembers