feat: add un-escape special symbols functionality #2426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to me that it is doing the opposite. With this function we will be able to display this three escaped characters: |
jakex7
reviewed
Aug 23, 2024
Comment on lines
+277
to
+279
| .replace(/&/g, '&') | ||
| .replace(/</g, '<') | ||
| .replace(/>/g, '>'); |
There was a problem hiding this comment.
Making an exception for some character just seems wrong. What about ' or "? There are dozens of characters that could be unescaped.
jakex7
reviewed
Aug 23, 2024
Comment on lines
+277
to
+279
| .replace(/&/g, '&') | ||
| .replace(/</g, '<') | ||
| .replace(/>/g, '>'); |
There was a problem hiding this comment.
Additionally, what about numeric character references? According to the spec, it's also a valid text content. Example:< can be represented as <, > as > and & as &
|
I guess we have to find another solution for that, that's why I closed that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2411
Motivation: the parse function does not un-escape text from the SVG element. It prevents displaying special characters (such as <, >, &, and others) in SVG text elements.
Test Plan
The example is available in the test-examples app as Test2411
Compatibility