From c6224b11c5039ed7294380f992b5c1b993e53ecf Mon Sep 17 00:00:00 2001 From: Ashley Wang Date: Fri, 30 Aug 2024 14:36:58 -0400 Subject: [PATCH] same wording for serviceOverrides --- codegen/cmd_test.go | 2 +- codegen/model/values/helm_chart_values.go | 2 +- .../test/name_override_chart/name_override_chart_reference.md | 2 +- codegen/test/name_override_chart/values.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/codegen/cmd_test.go b/codegen/cmd_test.go index c4274709..dcf55b62 100644 --- a/codegen/cmd_test.go +++ b/codegen/cmd_test.go @@ -599,7 +599,7 @@ var _ = Describe("Cmd", func() { painterNode := node.Content[0].Content[1] enabledMapField := painterNode.Content[0] - Expect(enabledMapField.HeadComment).To(ContainSubstring("Arbitrary overrides for the component's [deployment spec template](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/deployment-v1/), such as to set resource limits and requests. Format the overrides as YAML or JSON.")) + Expect(enabledMapField.HeadComment).To(ContainSubstring("Arbitrary overrides for the component's [deployment spec")) }) It("generates from templates using a name override", func() { diff --git a/codegen/model/values/helm_chart_values.go b/codegen/model/values/helm_chart_values.go index e99d6bfe..030927ea 100644 --- a/codegen/model/values/helm_chart_values.go +++ b/codegen/model/values/helm_chart_values.go @@ -65,7 +65,7 @@ type UserValues struct { // Overrides which can be set by the user DeploymentOverrides *appsv1.Deployment `json:"deploymentOverrides" desc:"Arbitrary overrides for the component's [deployment spec template](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/deployment-v1/), such as to set resource limits and requests. Format the overrides as YAML or JSON." omitChildren:"true"` - ServiceOverrides *v1.Service `json:"serviceOverrides" desc:"Arbitrary overrides for the component's [service template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/)." omitChildren:"true"` + ServiceOverrides *v1.Service `json:"serviceOverrides" desc:"Arbitrary overrides for the component's [service spec template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/)." omitChildren:"true"` } // document values structure for a container diff --git a/codegen/test/name_override_chart/name_override_chart_reference.md b/codegen/test/name_override_chart/name_override_chart_reference.md index 373f22f2..c606ade1 100755 --- a/codegen/test/name_override_chart/name_override_chart_reference.md +++ b/codegen/test/name_override_chart/name_override_chart_reference.md @@ -25,7 +25,7 @@ weight: 2 |overrideName.resources|struct|Container resource requirements. For more info, see the [Kubernetes documentation](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#resourcerequirements-v1-core).| | |overrideName.runAsUser|uint32|Static user ID to run the containers as. Unused if floatingUserId is 'true'.|10101| |overrideName.securityContext|struct|Container security context. Set to 'false' to omit the security context entirely. For more info, see the [Kubernetes documentation](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#securitycontext-v1-core).| | -|overrideName.serviceOverrides|struct|Arbitrary overrides for the component's [service template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/).| | +|overrideName.serviceOverrides|struct|Arbitrary overrides for the component's [service spec template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/).| | |overrideName.serviceType|string|Kubernetes service type. Can be either "ClusterIP", "NodePort", "LoadBalancer", or "ExternalName".| | |overrideName.sidecars|map[string, struct]|Optional configuration for the deployed containers.|{}| |overrideName.sidecars.|struct|Optional configuration for the deployed containers.| | diff --git a/codegen/test/name_override_chart/values.yaml b/codegen/test/name_override_chart/values.yaml index 0057d60d..a02a1a7f 100644 --- a/codegen/test/name_override_chart/values.yaml +++ b/codegen/test/name_override_chart/values.yaml @@ -28,7 +28,7 @@ overrideName: ports: {} # Static user ID to run the containers as. Unused if floatingUserId is 'true'. runAsUser: 10101 - # Arbitrary overrides for the component's [service + # Arbitrary overrides for the component's [service spec # template](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/). serviceOverrides: null # Kubernetes service type. Can be either "ClusterIP", "NodePort", "LoadBalancer",