Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to read the output and if interactive shells are disabled on Gerrit #53

Open
jpopadak opened this issue May 3, 2016 · 1 comment

Comments

@jpopadak
Copy link

jpopadak commented May 3, 2016

The SshConnection successfully opens a connection to Gerrit, executes the command, and then on its first readLine() call, the stream returns null. The GerritConnection object then keeps connecting and disconnecting every second without actually showing any errors to the outside world (minus the connect and disconnect events). It would be nice to receive an error message when some servers return the following output:

  ssh -p 29418 sshusername@hostname

    ****    Welcome to Gerrit Code Review    ****

    Hi John Doe, you have successfully connected over SSH.

    Unfortunately, interactive shells are disabled.
    To clone a hosted Git repository, use:

    git clone ssh://sshusername@hostname:29418/REPOSITORY_NAME.git

  Connection to hostname closed.
@dpursehouse
Copy link
Contributor

if interactive shells are disabled on Gerrit

Interactive shell is always disabled on Gerrit. There's no 'if' about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants