Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2.1 flow isn't easily compatible with mobile app authentication flows via WebViews #313

Open
mgoodfellow opened this issue Sep 5, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@mgoodfellow
Copy link

Hi,

As it stands, the new OAuth 2.1 connect screen isn't easily compatible with mobile apps for Android / iOS etc. This is because the flow opens up popup windows for external providers (Facebook / Google etc).

When working with WebViews, a popup window is complex because it isn't natively supported - workarounds exist, but become really problematic with this particular implementation because the popup is opened with about:blank and then redirected via JavaScript to the correct provider URL.

The old OAuth 2.0 flow continued these external provider logins within the current window which is far easier to work with for mobile apps/websites.

I would suggest something like a query parameter on the soundcloud login redirect, e.g. external_provider_mode=no_popup, and if this key isn't present it would default to popup which would be the same as the existing implementation.

Open to any thoughts regarding this!

Cheers

@youssefhassan
Copy link

Hey, I will share the word with our authentication team
cc @rbscgh

@youssefhassan
Copy link

I shared your thoughts with the auth team and they agreed on the concern and will be taken into account in future iterations. Is it blocking your integration?

@mgoodfellow
Copy link
Author

Hi @youssefhassan ,

Yes, this is a blocker for us at the moment. Users cannot login to our app if they login to SoundCloud with an external provider. There might be a hacky workaround that could make it work, but ideally we don’t want to go down that route.

@youssefhassan youssefhassan added the bug Something isn't working label Oct 5, 2024
@youssefhassan
Copy link

@mgoodfellow It's in our pipeline, sorry for the inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants