filesystem setting within lvm logical volume needs to be a required field

[jesbourne]

Cookbook version

4.1.12

Chef-client version

14.3.37

Platform Details

Ubuntu 16.04

Scenario:

When you use lvm_logical_volume and filesystem is not set, it seems to send a nil string to the mount resource's using it's fstype parameter. This is a required field for the mount resource and can't be a blank string.

Steps to Reproduce:

Use lvm_logical_volume without setting 'filesystem'.

Expected Result:

I was expecting it to automatically pull the filesystem, which is what the mount resource will do if no value is set here. Erroring and letting us know this is a required field would be fine too.

Actual Result:

This is the entry it added when filesystem wasn't set -
/dev/mapper/location /opt/mount defaults 0 0

Because this field isn't set, the regex that checks to see if the fstab entry already exists fails as there are only 5 fields in the entry - https://github.com/chef/chef/blob/master/lib/chef/provider/mount/mount.rb#L64

It will then add multiple duplicate entries, which will then cause the box to go into emergency mode when restarted.

[welcomebot]

Hey There
It looks like this is the first issue you've filed against the chef-cookbooks project. I'm here to offer you a bit of extra help to make sure we can quickly get back to you.
Make sure you've filled out all the fields in our issue template. Make sure you've provided us with the version of chef-client you're running, your operating system and the version of the cookbook. If you're not using the most up to date version of the cookbook then please make sure to update first. Lots of things change between versions even if you're issue isn't listed in the changelog. Finally please give us a detailed description of the issue you're having. The more we know about what you're trying to do, what actually happens, and how you can reproduce the problem, the better.

If you're looking for more immediate troubleshooting help make sure to check out #general on the Chef Community Slack. There's plenty of folks there willing to lend a helping hand. Thanks for the first issue. We hope we can get back to you soon with a solution.