-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-building of matrix-client-schildichat fails: path to webpack.config.js cannot be specified #3831
Comments
This is related to #3831 It: - adds some missing variables - version variable to branch variable conversion While it improves the situation, it still doesn't result in a working self-building feature, because: - cloning a repository containing submodules requires special care, as described here (https://github.com/SchildiChat/schildichat-desktop/blob/c03ef20e5dc0a88cec479c9711d9941aba48ab97/README.md#initial-build-setup) - we likely better clone a specific repository version from the very beginning, instead of trying to change subsequently (and having to re-initilize submodules) though that's very different than what we're doing elsewhere and is likely very wasteful - we can't just build a `Dockerfile`, we need to invoke `make setup` (`./setup.sh`) - it's likely that the `docker-src` directory is not reusable across versions or may require special handling to clean up files, etc.
In f19f3be I've pushed some obvious fixes. I have also adjusted the path to the As the commit message says, this does not result in a fixed self-building feature due to many other issues. Fixing it will require some more work. An alternative may be to remove the self-building feature from the Schildichat role. It probably never really worked to begin with. I also wonder if the element-web self-building feature works well still. Maybe it should be re-tested just in case and improved upon a bit. |
Thanks for checking! I tried to self-build Element Web, and it failed as you expected… Since I am not sure what is sensitive info or not, I'll send you log via Matrix → Sent. |
Playbook Configuration:
My
vars.yml
file looks like this:It was specified following
roles/custom/matrix-client-element/defaults/main.yml
as an example.v1.11.86-sc.0.test.0
was released here: https://github.com/SchildiChat/schildichat-desktop/releases/tag/v1.11.86-sc.0.test.0Matrix Server:
Ansible:
Problem description:
I tried to self-build SchildiChat Web client based on the latest pre-release to try it out.
With the error message I changed
matrix_client_schildichat_docker_src_files_path
to{{ matrix_client_schildichat_data_path }}/docker-src/element-web
(where webpack.config.js should exist) and ran the setup command, but it did not find/matrix/client-schildichat/docker-src/element-web/webpack.config.js
because the file moved to/matrix/client-schildichat/docker-src/element-web/element-web/webpack.config.js
for a reason which I do not know.So I changed
matrix_client_schildichat_docker_src_files_path
to{{ matrix_client_schildichat_data_path }}/docker-src/element-web/element-web
and ran the setup command again, and it failed again with the error message as below:Any pointer to proceed with self-building would be appreciated.
Client (please complete the following information): irrelevant
Additional context
Since the repository structure of https://github.com/SchildiChat/schildichat-desktop was greatly changed, the role might need update as well, maybe?
The text was updated successfully, but these errors were encountered: