JSON query generation generates nested optional while it should not #658
Comments
|
the critical part that breaks the loading seems to be "children": [
{
"line": {
"s": "object_8",
"p": "http://www.graceful17.org/shacl/sparnatural-config/object_related_to_event",
"o": "event_10",
"sType": "http://www.graceful17.org/shacl/sparnatural-config/object",
"oType": "http://www.graceful17.org/shacl/sparnatural-config/event",
"values": []
}
g17sn:object_related_to_event a sh:PropertyShape ;
rdfs:label "object related to event"@en ;
volipi:message "Tooltip for object related to event (This is only a query pattern)" ;
dash:searchWidget sparnatural:ListProperty ;
sh:class grace:event ;
sh:name "subject of" ;
sh:node g17sn:event ;
sh:nodeKind sh:IRI ;
sh:path [ sh:inversePath grace:event_related_to_object ] .When manually building the branch, the SPARQL forms this correctly: ?object_6 rdf:type <http://www.graceful17.org/ontology/object>;
^<http://www.graceful17.org/ontology/event_related_to_object> ?event_16.What is strange is that a short JSON loads fine as import {
"distinct": true,
"variables": [
{
"termType": "Variable",
"value": "object_1"
}
],
"order": null,
"branches": [
{
"line": {
"s": "object_1",
"p": "http://www.graceful17.org/shacl/sparnatural-config/object_related_to_event",
"o": "event_2",
"sType": "http://www.graceful17.org/shacl/sparnatural-config/object",
"oType": "http://www.graceful17.org/shacl/sparnatural-config/event",
"values": []
},
"children": []
}
]
} |
|
Probably unrelated but I also get this error when running the query |
|
Considering the line where it happens is looks more related to the presence of an "optional" clause in the query. I don't have time to investigate further right now. You have multiple nested optionals, which is bad. Nested optionals are not supported in Sparnatural. |
|
Understood, and no worries. Yet, the query was built this way, including the nested optionals which are sometimes needed, through Sparnatural and executed without problems. It's only the loading if exposed to another session that fails. |
Sparnatural does not support that. The nested optional you have in you JSON export are buggy, they shouldn't be here. Only the outermost criteria should be flagged as optional. |
tfrancart
changed the title
|
I see! Thanks for the fix (I will need to wait for the next release though)! |
|
Well, for now the JSON and SPARQL are generated separately. |
related to #646 and #647
When importing (
sparnatural.loadQuery(json)) the following Sparnatural binding (successfully built, executed, and exported with Sparnatural) I get a console error (see below) and only half of the branches are built in the UI. Why is that?Import
{ "distinct": true, "variables": [ { "termType": "Variable", "value": "place_1" }, { "termType": "Variable", "value": "type_4" }, { "termType": "Variable", "value": "institution_6" }, { "termType": "Variable", "value": "name_14" }, { "expression": { "type": "aggregate", "aggregation": "min", "distinct": false, "expression": { "termType": "Variable", "value": "date_value_16" } }, "variable": { "termType": "Variable", "value": "date_value_16_min" } }, { "expression": { "type": "aggregate", "aggregation": "count", "distinct": false, "expression": { "termType": "Variable", "value": "object_8" } }, "variable": { "termType": "Variable", "value": "object_8_count" } } ], "order": "asc", "branches": [ { "line": { "s": "place_1", "p": "http://www.graceful17.org/shacl/sparnatural-config/called", "o": "name_2", "sType": "http://www.graceful17.org/shacl/sparnatural-config/place", "oType": "http://www.graceful17.org/shacl/sparnatural-config/name", "values": [] }, "children": [] }, { "line": { "s": "place_1", "p": "http://www.graceful17.org/shacl/sparnatural-config/has_main_type", "o": "type_4", "sType": "http://www.graceful17.org/shacl/sparnatural-config/place", "oType": "http://www.graceful17.org/shacl/sparnatural-config/type", "values": [] }, "children": [] }, { "line": { "s": "place_1", "p": "http://www.graceful17.org/shacl/sparnatural-config/is_primary_place_of", "o": "institution_6", "sType": "http://www.graceful17.org/shacl/sparnatural-config/place", "oType": "http://www.graceful17.org/shacl/sparnatural-config/institution", "values": [] }, "children": [ { "line": { "s": "institution_6", "p": "http://www.graceful17.org/shacl/sparnatural-config/holds_immaterial_object", "o": "object_8", "sType": "http://www.graceful17.org/shacl/sparnatural-config/institution", "oType": "http://www.graceful17.org/shacl/sparnatural-config/object", "values": [] }, "children": [ { "line": { "s": "object_8", "p": "http://www.graceful17.org/shacl/sparnatural-config/object_related_to_event", "o": "event_10", "sType": "http://www.graceful17.org/shacl/sparnatural-config/object", "oType": "http://www.graceful17.org/shacl/sparnatural-config/event", "values": [] }, "children": [ { "line": { "s": "event_10", "p": "http://www.graceful17.org/shacl/sparnatural-config/event_date", "o": "date_12", "sType": "http://www.graceful17.org/shacl/sparnatural-config/event", "oType": "http://www.graceful17.org/shacl/sparnatural-config/date", "values": [] }, "children": [ { "line": { "s": "date_12", "p": "http://www.graceful17.org/shacl/sparnatural-config/called", "o": "name_14", "sType": "http://www.graceful17.org/shacl/sparnatural-config/date", "oType": "http://www.graceful17.org/shacl/sparnatural-config/name", "values": [] }, "children": [], "optional": true }, { "line": { "s": "date_12", "p": "http://www.graceful17.org/shacl/sparnatural-config/started", "o": "date_value_16", "sType": "http://www.graceful17.org/shacl/sparnatural-config/date", "oType": "http://www.graceful17.org/shacl/sparnatural-config/date_value", "values": [] }, "children": [], "optional": true } ], "optional": true } ], "optional": true } ], "optional": true } ], "optional": true } ] }Console
Full Log
The text was updated successfully, but these errors were encountered: