Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefly detector list should include more than just detectors #309

Open
canismarko opened this issue Nov 19, 2024 · 1 comment
Open

Firefly detector list should include more than just detectors #309

canismarko opened this issue Nov 19, 2024 · 1 comment
Assignees

Comments

@canismarko
Copy link
Contributor

There are some situations where you want an Ophyd device to be included as a detector even though it's not what we typically think of as a detector. An example from the recent beamtime with Jerry Seidler's group.

Each crystal analyzer has the following structure, where there individual items are positioners.

Analyzer
|- energy
|- horizontal
|- vertical
|- crystal_yaw
|- reflection
|- ...

Users wanted to do a scan on analyzer.energy, e.g. bp.scan([I0, IpreKB], analyzer.energy, 7800, 7820). However, at each point in the scan, they also wanted to know the values for the other positioners, especially energy.horizontal. In Bluesky, this is easy, just include the analyzer as a detector: bp.scan([I0, IpreKB, analyzer], analyzer.energy, 7800, 7820). However Firefly only shows things with the "detectors" label right now.

Proposed Behavior

99% of the time, the list of options should just be things with the "detectors" label. However, we need a way to also include all the devices.

Maybe we can re-use the component selector for this?

Maybe the detector list is something where you can choose from a list and have to move the selection over to a second list. That way the source list could change depending on whether you want just detectors, or everything. Just an idea, not necessarily the best option. Here's a mockup of what I was thinking.

image

@canismarko
Copy link
Contributor Author

Another thought I had, instead of putting tabs into the detector selector, maybe we should put a combobox at the top of the component selector with all the different labels, like "detectors", "ion_chambers", "motors", "all devices", etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants