Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xafs_scan plan, energies are not sorted #328

Open
Cathyhjj opened this issue Dec 12, 2024 · 3 comments
Open

xafs_scan plan, energies are not sorted #328

Cathyhjj opened this issue Dec 12, 2024 · 3 comments
Assignees

Comments

@Cathyhjj
Copy link
Collaborator

Describe the bug

in this xafs scan, the first point of the second region is smaller than the last energy point of the first region, see the scatter plot of the energy as a function of the point number; This will raise an error when processing with larch, because it verifies that energies should be increasing in autobk function

The data uid: 6fc4ee04-ba36-4642-b518-48a685b2eb1d

image

@Cathyhjj
Copy link
Collaborator Author

With discussion with @canismarko, this occurs because that was how it was set in the plan scan args

@canismarko
Copy link
Contributor

After discussion with the group, we think it belongs in the haven.energy_ranges.merge_ranges function.

@canismarko
Copy link
Contributor

One option for this is for merge_ranges to round to the precision of the positioner, which will make removing duplicates much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants