Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not super helpful error messages #3635

Closed
anssiko opened this issue Jun 2, 2021 · 13 comments
Closed

Not super helpful error messages #3635

anssiko opened this issue Jun 2, 2021 · 13 comments

Comments

@anssiko
Copy link
Contributor

anssiko commented Jun 2, 2021

pr-push.yml fails with:

 Document on track but no previous version.
        Plugin: w3c/headers
          Hint: Add [previousMaturity](https://respec.org/docs/#previousMaturity) and [previousPublishDate](https://respec.org/docs/#previousPublishDate) to ReSpec’s config.

via https://github.com/w3c/device-posture/runs/2727557242?check_suite_focus=true

@xfq

@xfq
Copy link
Contributor

xfq commented Jun 2, 2021

It seems that ReSpec (rather than Pubrules) emitted the error.

@marcoscaceres Can I get a pointer to more information on this error?

@xfq
Copy link
Contributor

xfq commented Jun 3, 2021

The problem seems to have been fixed. Closing.

@xfq xfq closed this as completed Jun 3, 2021
@anssiko
Copy link
Contributor Author

anssiko commented Jun 3, 2021

Thanks @xfq!

@marcoscaceres
Copy link
Contributor

Sorry, I totally missed this! Glad it was resolved.

@marcoscaceres
Copy link
Contributor

marcoscaceres commented Jun 15, 2021

Oh! about this error... sometimes, publishing to TR more than once per day fails. It's a known spec-prod issue.

If it happens, rerunning the action again sometimes fixes it... worst case, run the action again the next day and it works 😇

@anssiko
Copy link
Contributor Author

anssiko commented Jun 15, 2021

Thanks for the tip, that explains why this was hard to repro.

It'd be nice if this could fail with an informative error message.

Meanwhile, let's say one TR publication a day is a spec-prod feature and not a bug 😀

@marcoscaceres
Copy link
Contributor

It'd be nice if this could fail with an informative error message.

I think this was the original:

 Document on track but no previous version.
        Plugin: w3c/headers
          Hint: Add [previousMaturity](https://respec.org/docs/#previousMaturity) and [previousPublishDate](https://respec.org/docs/#previousPublishDate) to ReSpec’s config.

We should probably reword that as:

Document is on the on W3C's Recommendation track, but it is lacking a "previous version" link.

And the Plugin should be moved last. The hint test is ok, I think.

@anssiko, wdyt? Or are the errors not helpful at all?

@marcoscaceres
Copy link
Contributor

Reopening and moving to ReSpec...

@marcoscaceres marcoscaceres reopened this Jun 15, 2021
@marcoscaceres marcoscaceres changed the title Build fails Not super helpful error messages Jun 15, 2021
@marcoscaceres marcoscaceres transferred this issue from w3c/device-posture Jun 15, 2021
@marcoscaceres
Copy link
Contributor

@anssiko, any "real user" feedback you can provide us would be super helpful. Will do our best to improve things.

@anssiko
Copy link
Contributor Author

anssiko commented Jun 15, 2021

I was actually reacting to "publishing to TR more than once per day fails" case. I was wondering if spec-prod could detect that and warn the operation might fail, if that's the case. Optimally, it wouldn't fail.

@marcoscaceres
Copy link
Contributor

"publishing to TR more than once per day fails" case.

Ah, it does report a fail, but the errors are also quite cryptic:
w3c/spec-prod#82

@sidvishnoi
Copy link
Member

publishing to TR more than once per day fails

That shouldn't be happening. It's probably some other bug where spec-prod didn't set right right respecConfig. Will investigate.

@marcoscaceres
Copy link
Contributor

We did a bunch of work on this in #3637. Closing for now and we can fix up any specifically unhelpful ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants