-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BufferGeometry need to be called with new
#139
Comments
Hello! Thank you very much for this amazing library @spite. I made a new version of a library using vite and typescript. I would be happy to PR it on your repo but I went a bit yolo and had to use --allow-unrelated-histories. Temporary I published it on npm under the name meshline. It should work the same way, and it now exports es(2.89kb brotli) and umd(3.13kb). If anyone could take over in cleaning the code that would be amazing. Here a working example with react-three/fiber: EDIT: |
Hi @RenaudRohlinger, if you build it using typescript, it's better to also generate the d.ts file and include them in the package so other typescript users can use it too. |
|
Well, already an PR #143 but.... |
interested in this fix |
The code uses https://github.com/spite/THREE.MeshLine/blob/master/src/THREE.MeshLine.js#L12
however recently threejs has some changes to make use of ES6 classes
https://github.com/mrdoob/three.js/wiki/Migration-Guide#127--128
need an update now.
The text was updated successfully, but these errors were encountered: